github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-09 07:13:35 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #797] [MERGED] feat(auth): add ForceUserInfo option to OpenID provider #951

New Issue
Closed
opened 2025-11-01 21:07:53 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:07:53 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/797
Author: @maggch97
Created: 5/19/2025
Status: ✅ Merged
Merged: 5/20/2025
Merged by: @kolaente

Base: main ← Head: user/weijiezhao/forceUserInfo

📝 Commits (4)

  • d0c4f1c feat(auth): add ForceUserInfo option to OpenID provider
  • 4c1e5a9 Add unit test for ForceUserInfo
  • c685639 Merge branch 'main' into user/weijiezhao/forceUserInfo
  • e2029c7 Remove provideName param

📊 Changes

4 files changed (+177 additions, -19 deletions)

View changed files

📝 config-raw.json (+5 -0)
📝 pkg/modules/auth/openid/openid.go (+34 -19)
📝 pkg/modules/auth/openid/openid_test.go (+124 -0)
📝 pkg/modules/auth/openid/providers.go (+14 -0)

📄 Description

Add ForceUserInfo option to OpenID provider

Problem

When using Casdoor as an OpenID provider, there's an inconsistency between the user information in the JWT token and the UserInfo endpoint. The token contains the user's unique ID in the name field, while the UserInfo endpoint correctly returns the user's display name.

Solution

This PR adds a new ForceUserInfo option to the OpenID provider configuration. When enabled, it forces the use of the UserInfo endpoint to retrieve user information instead of relying on claims from the ID token.

Impact

  • Default behavior remains unchanged (backward compatible)
  • New option allows administrators to force using UserInfo endpoint data
  • Particularly useful for providers like Casdoor that don't fully comply with OIDC standards

Related

I've opened an issue in the Casdoor repository (https://github.com/casdoor/casdoor/issues/3806) to discuss the root cause. However, changing Casdoor's token structure might cause significant compatibility issues for existing integrations, so it's unclear if this can be fixed at the provider level. This PR provides a workaround in Vikunja that doesn't affect existing functionality.

Docs PR: https://github.com/go-vikunja/website/pull/107

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/797 **Author:** [@maggch97](https://github.com/maggch97) **Created:** 5/19/2025 **Status:** ✅ Merged **Merged:** 5/20/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `user/weijiezhao/forceUserInfo` --- ### 📝 Commits (4) - [`d0c4f1c`](https://github.com/go-vikunja/vikunja/commit/d0c4f1c05cc0c5234c5589c7d3c7f3a45f6a57f0) feat(auth): add ForceUserInfo option to OpenID provider - [`4c1e5a9`](https://github.com/go-vikunja/vikunja/commit/4c1e5a93d2dcaf66fa456b15db79670b6aa2a24a) Add unit test for ForceUserInfo - [`c685639`](https://github.com/go-vikunja/vikunja/commit/c6856395ed187a0d7ff9e1fd2434e1338544ba84) Merge branch 'main' into user/weijiezhao/forceUserInfo - [`e2029c7`](https://github.com/go-vikunja/vikunja/commit/e2029c7be347eef45b81d0cba150ce8cb41c8141) Remove provideName param ### 📊 Changes **4 files changed** (+177 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `config-raw.json` (+5 -0) 📝 `pkg/modules/auth/openid/openid.go` (+34 -19) 📝 `pkg/modules/auth/openid/openid_test.go` (+124 -0) 📝 `pkg/modules/auth/openid/providers.go` (+14 -0) </details> ### 📄 Description # Add ForceUserInfo option to OpenID provider ## Problem When using Casdoor as an OpenID provider, there's an inconsistency between the user information in the JWT token and the UserInfo endpoint. The token contains the user's unique ID in the `name` field, while the UserInfo endpoint correctly returns the user's display name. ## Solution This PR adds a new `ForceUserInfo` option to the OpenID provider configuration. When enabled, it forces the use of the UserInfo endpoint to retrieve user information instead of relying on claims from the ID token. ## Impact - Default behavior remains unchanged (backward compatible) - New option allows administrators to force using UserInfo endpoint data - Particularly useful for providers like Casdoor that don't fully comply with OIDC standards ## Related I've opened an issue in the Casdoor repository (https://github.com/casdoor/casdoor/issues/3806) to discuss the root cause. However, changing Casdoor's token structure might cause significant compatibility issues for existing integrations, so it's unclear if this can be fixed at the provider level. This PR provides a workaround in Vikunja that doesn't affect existing functionality. Docs PR: https://github.com/go-vikunja/website/pull/107 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:07:53 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#951
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?