github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-24 08:48:48 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1769] [MERGED] fix: migrate Sentry integration to SDK v8 API #9509

New Issue
Closed
opened 2026-04-23 09:02:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:02:20 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1769
Author: @Copilot
Created: 11/7/2025
Status: ✅ Merged
Merged: 11/7/2025
Merged by: @kolaente

Base: main ← Head: copilot/fix-vue-router-instrumentation

📝 Commits (4)

  • 31d3ee1 Initial plan
  • 5d79a39 Initial plan for fixing Sentry vueRouterInstrumentation error
  • 91acf8f fix: update Sentry integration to SDK v8 API
  • d841a41 update lockfil2

📊 Changes

4 files changed (+23057 additions, -49 deletions)

View changed files

➕ frontend/package-lock.json (+23055 -0)
📝 frontend/package.json (+0 -1)
📝 frontend/pnpm-lock.yaml (+0 -44)
📝 frontend/src/sentry.ts (+2 -4)

📄 Description

Webapp becomes unresponsive after editing task descriptions due to vueRouterInstrumentation is not a function runtime error. The codebase uses @sentry/vue v10.x (SDK v8) but imports from deprecated @sentry/tracing v7.x, which lacks the vueRouterInstrumentation export.

Changes

frontend/src/sentry.ts

  • Remove import from deprecated @sentry/tracing
  • Replace new Integrations.BrowserTracing() with Sentry.browserTracingIntegration()
  • Pass router directly as option instead of via removed vueRouterInstrumentation() helper

frontend/package.json

  • Remove @sentry/tracing dependency

Before/After

// Before (SDK v7 API)
const {Integrations} = await import('@sentry/tracing')
integrations: [
  new Integrations.BrowserTracing({
    routingInstrumentation: Sentry.vueRouterInstrumentation(router),
    tracingOrigins: ['localhost', /^\//],
  }),
]

// After (SDK v8 API)
integrations: [
  Sentry.browserTracingIntegration({
    router,
  }),
]

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
  • googlechromelabs.github.io
    • Triggering command: node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: node install.mjs (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-linux64.zip
    • Triggering command: node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>vueRouterInstrumentation is not a function after editing description</issue_title>
<issue_description>### Description

When saving after editing the description of a task an uncaught exception is thrown which leads to the webapp becoming unresponsive. Only a page reload restores functionality of the app. Fortunately, the changes of the comment get saved though.

The error from the console:

sentry-CLN04XeV.js:1 
 Uncaught (in promise) TypeError: n.vueRouterInstrumentation is not a function
    at Module.l (sentry-CLN04XeV.js:1:433)
l	@	sentry-CLN04XeV.js:1
await in l		
(anonymous)	@	index-y7S2fyRg.js:674
Promise.then		
(anonymous)	@	index-y7S2fyRg.js:674
Promise.then		
(anonymous)	@	index-y7S2fyRg.js:674

This behavior occurs since a couple of days.

Vikunja Version

Version: v1.0.0-rc2-220-77779350

Browser and version

Microsoft Edge Version 142.0.3595.53 (Official build) (64-bit)

Can you reproduce the bug on the Vikunja demo site?

Yes

Screenshots

No response</issue_description>

<agent_instructions>This might be related to the build or the sentry integration or somtheing like that.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1769 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 11/7/2025 **Status:** ✅ Merged **Merged:** 11/7/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `copilot/fix-vue-router-instrumentation` --- ### 📝 Commits (4) - [`31d3ee1`](https://github.com/go-vikunja/vikunja/commit/31d3ee14e86a5fd43ed5cd805368ddca11f3fc6c) Initial plan - [`5d79a39`](https://github.com/go-vikunja/vikunja/commit/5d79a3944f343b42b52d9c40355f399e4e359c43) Initial plan for fixing Sentry vueRouterInstrumentation error - [`91acf8f`](https://github.com/go-vikunja/vikunja/commit/91acf8fc09324f9695b89e2e7affa8b762e8b7d5) fix: update Sentry integration to SDK v8 API - [`d841a41`](https://github.com/go-vikunja/vikunja/commit/d841a410b6c7b347eac2abfe65bb4d4d6c1c092f) update lockfil2 ### 📊 Changes **4 files changed** (+23057 additions, -49 deletions) <details> <summary>View changed files</summary> ➕ `frontend/package-lock.json` (+23055 -0) 📝 `frontend/package.json` (+0 -1) 📝 `frontend/pnpm-lock.yaml` (+0 -44) 📝 `frontend/src/sentry.ts` (+2 -4) </details> ### 📄 Description Webapp becomes unresponsive after editing task descriptions due to `vueRouterInstrumentation is not a function` runtime error. The codebase uses `@sentry/vue` v10.x (SDK v8) but imports from deprecated `@sentry/tracing` v7.x, which lacks the `vueRouterInstrumentation` export. ## Changes **`frontend/src/sentry.ts`** - Remove import from deprecated `@sentry/tracing` - Replace `new Integrations.BrowserTracing()` with `Sentry.browserTracingIntegration()` - Pass router directly as option instead of via removed `vueRouterInstrumentation()` helper **`frontend/package.json`** - Remove `@sentry/tracing` dependency ## Before/After ```typescript // Before (SDK v7 API) const {Integrations} = await import('@sentry/tracing') integrations: [ new Integrations.BrowserTracing({ routingInstrumentation: Sentry.vueRouterInstrumentation(router), tracingOrigins: ['localhost', /^\//], }), ] // After (SDK v8 API) integrations: [ Sentry.browserTracingIntegration({ router, }), ] ``` > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `download.cypress.io` > - `googlechromelabs.github.io` > - Triggering command: `node install.mjs` (dns block) > - `https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-headless-shell-linux64.zip` > - Triggering command: `node install.mjs` (http block) > - `https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-linux64.zip` > - Triggering command: `node install.mjs` (http block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/go-vikunja/vikunja/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>vueRouterInstrumentation is not a function after editing description</issue_title> > <issue_description>### Description > > When saving after editing the description of a task an uncaught exception is thrown which leads to the webapp becoming unresponsive. Only a page reload restores functionality of the app. Fortunately, the changes of the comment get saved though. > > The error from the console: > ``` > sentry-CLN04XeV.js:1 > Uncaught (in promise) TypeError: n.vueRouterInstrumentation is not a function > at Module.l (sentry-CLN04XeV.js:1:433) > l @ sentry-CLN04XeV.js:1 > await in l > (anonymous) @ index-y7S2fyRg.js:674 > Promise.then > (anonymous) @ index-y7S2fyRg.js:674 > Promise.then > (anonymous) @ index-y7S2fyRg.js:674 > ``` > > This behavior occurs since a couple of days. > > ### Vikunja Version > > Version: v1.0.0-rc2-220-77779350 > > ### Browser and version > > Microsoft Edge Version 142.0.3595.53 (Official build) (64-bit) > > ### Can you reproduce the bug on the Vikunja demo site? > > Yes > > ### Screenshots > > _No response_</issue_description> > > <agent_instructions>This might be related to the build or the sentry integration or somtheing like that.</agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes go-vikunja/vikunja#1763 <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:02:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9509