github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-11 08:20:40 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1738] [MERGED] fix(task): remove duplicate close button on mobile task detail #9487

New Issue
Closed
opened 2026-04-23 09:01:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-23 09:01:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1738
Author: @kolaente
Created: 10/31/2025
Status: ✅ Merged
Merged: 3/3/2026
Merged by: @kolaente

Base: main ← Head: claude/fix-duplicate-close-button-mobile-011CUfbqZNZYoki8vXzWMGFS

📝 Commits (2)

  • 768b29e fix: remove duplicate close button on mobile task detail view
  • 9c13e67 fix(test): update mobile kanban test to use close button instead of back button

📊 Changes

2 files changed (+6 additions, -6 deletions)

View changed files

📝 frontend/src/views/tasks/TaskDetailView.vue (+2 -3)
📝 frontend/tests/e2e/task/task.spec.ts (+4 -3)

📄 Description

When viewing a task in modal mode on mobile, both a back button and a close button were displayed, causing confusion. The back button condition !isModal || isMobile meant it would show on mobile even in modal mode.

This fix changes the back button to only display when not in modal mode (!isModal), ensuring only the close button appears when viewing tasks in a modal on mobile devices.

Also removed the now-unused isMobile variable and its import.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1738 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 10/31/2025 **Status:** ✅ Merged **Merged:** 3/3/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `claude/fix-duplicate-close-button-mobile-011CUfbqZNZYoki8vXzWMGFS` --- ### 📝 Commits (2) - [`768b29e`](https://github.com/go-vikunja/vikunja/commit/768b29e83cc58f101cbf892901aa8b9b795f26b4) fix: remove duplicate close button on mobile task detail view - [`9c13e67`](https://github.com/go-vikunja/vikunja/commit/9c13e674d171a598f1ae81ed3c4f4d4923084896) fix(test): update mobile kanban test to use close button instead of back button ### 📊 Changes **2 files changed** (+6 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/views/tasks/TaskDetailView.vue` (+2 -3) 📝 `frontend/tests/e2e/task/task.spec.ts` (+4 -3) </details> ### 📄 Description When viewing a task in modal mode on mobile, both a back button and a close button were displayed, causing confusion. The back button condition `!isModal || isMobile` meant it would show on mobile even in modal mode. This fix changes the back button to only display when not in modal mode (`!isModal`), ensuring only the close button appears when viewing tasks in a modal on mobile devices. Also removed the now-unused `isMobile` variable and its import. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-23 09:01:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#9487
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?