github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2656] feat: support all days of the week as first day of the week #8435

New Issue
Open
opened 2026-04-20 18:13:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:13:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2656
Author: @xela-zone
Created: 4/18/2026
Status: 🔄 Open

Base: main ← Head: feat/all-days-week-start

📝 Commits (6)

  • 23258f0 fix(user): correct week_start validation range
  • 3835457 feat(user): support all weekdays as week start
  • 397e132 test(user): add tests for updating week start day and verifying date picker behavior
  • 70582b9 fix(frontend): use import.meta.env.MODE instead of DEV for testid directive
  • ffed02d fix(frontend): respect week_start setting when language is not explicitly set
  • 9287a2f test(e2e): use ISOString for date seeding to prevent timezone parsing errors

📊 Changes

7 files changed (+78 additions, -14 deletions)

View changed files

📝 frontend/src/directives/testid.ts (+1 -1)
📝 frontend/src/helpers/useFlatpickrLanguage.ts (+7 -6)
📝 frontend/src/i18n/lang/en.json (+5 -0)
📝 frontend/src/views/user/settings/General.vue (+6 -0)
📝 frontend/tests/e2e/project/project-view-gantt.spec.ts (+29 -2)
📝 frontend/tests/e2e/user/settings.spec.ts (+29 -4)
📝 pkg/routes/api/v1/user_settings.go (+1 -1)

📄 Description

This PR adds support for all days of the week as the "first day of the week" in user settings.

Changes:

  • Backend: Fixed week_start validation in user_settings.go to use range(0|6) (previously allowed an invalid value).

  • Frontend: Added missing Tuesday-Saturday translation keys and updated the settings dropdown options.

  • Testing: Added a permanent E2E test case in settings.spec.ts using the modern getByLabel pattern to verify persistence across reloads.

  • Docs: Added GEMINI.md symlink.

    Verified with mage test:e2e and full linting suite.

    idea and initial editing done by me, e2e testing and range validation found and done by Gemini

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2656 **Author:** [@xela-zone](https://github.com/xela-zone) **Created:** 4/18/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feat/all-days-week-start` --- ### 📝 Commits (6) - [`23258f0`](https://github.com/go-vikunja/vikunja/commit/23258f041e60370b757ecfb94017700ed68bd11f) fix(user): correct week_start validation range - [`3835457`](https://github.com/go-vikunja/vikunja/commit/3835457789aa1cbeb41ea1e35583f1e78aad3d79) feat(user): support all weekdays as week start - [`397e132`](https://github.com/go-vikunja/vikunja/commit/397e1321d87c3569f3b6e4f7a3fc9c5e1ee7c5ef) test(user): add tests for updating week start day and verifying date picker behavior - [`70582b9`](https://github.com/go-vikunja/vikunja/commit/70582b94f4610dd7011ef74d02f6ca3fffc093ea) fix(frontend): use import.meta.env.MODE instead of DEV for testid directive - [`ffed02d`](https://github.com/go-vikunja/vikunja/commit/ffed02dfe258ca3c90002773702575778a5e6649) fix(frontend): respect week_start setting when language is not explicitly set - [`9287a2f`](https://github.com/go-vikunja/vikunja/commit/9287a2ff01666f99e48e557cac07328087fe5bca) test(e2e): use ISOString for date seeding to prevent timezone parsing errors ### 📊 Changes **7 files changed** (+78 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/directives/testid.ts` (+1 -1) 📝 `frontend/src/helpers/useFlatpickrLanguage.ts` (+7 -6) 📝 `frontend/src/i18n/lang/en.json` (+5 -0) 📝 `frontend/src/views/user/settings/General.vue` (+6 -0) 📝 `frontend/tests/e2e/project/project-view-gantt.spec.ts` (+29 -2) 📝 `frontend/tests/e2e/user/settings.spec.ts` (+29 -4) 📝 `pkg/routes/api/v1/user_settings.go` (+1 -1) </details> ### 📄 Description This PR adds support for all days of the week as the "first day of the week" in user settings. **Changes:** - **Backend:** Fixed `week_start` validation in `user_settings.go` to use `range(0|6)` (previously allowed an invalid value). - **Frontend:** Added missing Tuesday-Saturday translation keys and updated the settings dropdown options. - **Testing:** Added a permanent E2E test case in `settings.spec.ts` using the modern `getByLabel` pattern to verify persistence across reloads. - **Docs:** Added `GEMINI.md` symlink. Verified with `mage test:e2e` and full linting suite. idea and initial editing done by me, e2e testing and range validation found and done by Gemini --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:13:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8435
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?