github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2651] Fix user count metrics not updated on API user create/delete #8432

New Issue
Open
opened 2026-04-20 18:12:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:12:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2651
Author: @booxter
Created: 4/16/2026
Status: 🔄 Open

Base: main ← Head: fix-user-count-metrics-event-dispatch

📝 Commits (3)

  • c58b739 Fix metric help text for number of users
  • 6168339 Dispatch queued user create event after commit
  • 411ead4 Dispatch user delete event and decrement user metrics

📊 Changes

10 files changed (+125 additions, -1 deletions)

View changed files

📝 pkg/metrics/metrics.go (+1 -1)
📝 pkg/models/user_delete.go (+9 -0)
📝 pkg/models/user_delete_test.go (+42 -0)
📝 pkg/modules/auth/openid/openid.go (+5 -0)
📝 pkg/routes/api/v1/login.go (+3 -0)
📝 pkg/routes/api/v1/user_register.go (+3 -0)
📝 pkg/user/events.go (+10 -0)
📝 pkg/user/listeners.go (+15 -0)
📝 pkg/user/user_test.go (+34 -0)
📝 pkg/webtests/register_test.go (+3 -0)

📄 Description

  • Fix metric help text for number of users
  • Dispatch queued user create event after commit
  • Dispatch user delete event and decrement user metrics

Fixes #2650

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2651 **Author:** [@booxter](https://github.com/booxter) **Created:** 4/16/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix-user-count-metrics-event-dispatch` --- ### 📝 Commits (3) - [`c58b739`](https://github.com/go-vikunja/vikunja/commit/c58b739a50dceb38c42b254b40c9f0f3f7b8095a) Fix metric help text for number of users - [`6168339`](https://github.com/go-vikunja/vikunja/commit/6168339c0775a98f475400c2558ec5432641e176) Dispatch queued user create event after commit - [`411ead4`](https://github.com/go-vikunja/vikunja/commit/411ead481f45c98fef38bb34cbf58110c9d96872) Dispatch user delete event and decrement user metrics ### 📊 Changes **10 files changed** (+125 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/metrics/metrics.go` (+1 -1) 📝 `pkg/models/user_delete.go` (+9 -0) 📝 `pkg/models/user_delete_test.go` (+42 -0) 📝 `pkg/modules/auth/openid/openid.go` (+5 -0) 📝 `pkg/routes/api/v1/login.go` (+3 -0) 📝 `pkg/routes/api/v1/user_register.go` (+3 -0) 📝 `pkg/user/events.go` (+10 -0) 📝 `pkg/user/listeners.go` (+15 -0) 📝 `pkg/user/user_test.go` (+34 -0) 📝 `pkg/webtests/register_test.go` (+3 -0) </details> ### 📄 Description - **Fix metric help text for number of users** - **Dispatch queued user create event after commit** - **Dispatch user delete event and decrement user metrics** Fixes #2650 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:12:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8432
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?