github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-16 23:11:04 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2634] [MERGED] refactor(frontend): split FormField into composable form primitives #8418

New Issue
Closed
opened 2026-04-20 18:12:22 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:12:22 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2634
Author: @tink-bot
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/17/2026
Merged by: @kolaente

Base: main ← Head: refactor-form-components

📝 Commits (7)

  • 30bcc1c feat(frontend): add FormInput primitive component
  • 2f4d0f0 feat(frontend): add FormSelect primitive component
  • 2690a20 feat(frontend): add FormCheckbox primitive component
  • 26bf198 refactor(frontend): support two-col layout on FormField
  • 40481fe refactor(frontend): use form primitives in user settings General view
  • 5b8af5e refactor(frontend): use form primitives in WebhookManager
  • 600d38e refactor(frontend): use FormCheckbox for remember-me on Login

📊 Changes

11 files changed (+980 additions, -488 deletions)

View changed files

➕ frontend/src/components/input/FormCheckbox.test.ts (+42 -0)
➕ frontend/src/components/input/FormCheckbox.vue (+41 -0)
📝 frontend/src/components/input/FormField.test.ts (+60 -1)
📝 frontend/src/components/input/FormField.vue (+73 -33)
➕ frontend/src/components/input/FormInput.test.ts (+123 -0)
➕ frontend/src/components/input/FormInput.vue (+78 -0)
➕ frontend/src/components/input/FormSelect.test.ts (+175 -0)
➕ frontend/src/components/input/FormSelect.vue (+100 -0)
📝 frontend/src/components/misc/WebhookManager.vue (+28 -48)
📝 frontend/src/views/user/Login.vue (+5 -10)
📝 frontend/src/views/user/settings/General.vue (+255 -396)

📄 Description

Introduces FormInput, FormSelect, and FormCheckbox primitives alongside a reshaped FormField (now supporting a two-col layout) so settings pages stop hand-rolling Bulma .field/.control/.input/.select markup — making a future Bulma removal a scoped, per-primitive change.

Migrates: General.vue (31 fields), WebhookManager.vue, and the remember-me checkbox on Login.vue. ApiTokens.vue, EditTeam.vue, Register.vue, and PasswordReset.vue either already use FormField or contain only composite layouts that don't fit the primitives cleanly; left for the follow-up migration.

Test plan

  • Open Settings → General and verify every row renders, inputs/selects/checkboxes work, and saving persists.
  • Open a project's Webhooks and exercise the create form (target URL, secret, basic-auth toggle).
  • Log in with "remember me" toggled on.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2634 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/17/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `refactor-form-components` --- ### 📝 Commits (7) - [`30bcc1c`](https://github.com/go-vikunja/vikunja/commit/30bcc1c4598e09937a980f4241d6c6cf7b4ea021) feat(frontend): add FormInput primitive component - [`2f4d0f0`](https://github.com/go-vikunja/vikunja/commit/2f4d0f09929944494c6c4f39c035440175f5ead5) feat(frontend): add FormSelect primitive component - [`2690a20`](https://github.com/go-vikunja/vikunja/commit/2690a2099c078f71cbac7ce60b025b33fc4adf34) feat(frontend): add FormCheckbox primitive component - [`26bf198`](https://github.com/go-vikunja/vikunja/commit/26bf19879b65bb486677e97e82e0ca57de55fb55) refactor(frontend): support two-col layout on FormField - [`40481fe`](https://github.com/go-vikunja/vikunja/commit/40481fec007194b72bfcdc939d1fca96b3b4de2f) refactor(frontend): use form primitives in user settings General view - [`5b8af5e`](https://github.com/go-vikunja/vikunja/commit/5b8af5e7b0f8817b3652eeaac1d868ec54b8b636) refactor(frontend): use form primitives in WebhookManager - [`600d38e`](https://github.com/go-vikunja/vikunja/commit/600d38ed62094f4c2c0f4020063fe3d2fa8bbca5) refactor(frontend): use FormCheckbox for remember-me on Login ### 📊 Changes **11 files changed** (+980 additions, -488 deletions) <details> <summary>View changed files</summary> ➕ `frontend/src/components/input/FormCheckbox.test.ts` (+42 -0) ➕ `frontend/src/components/input/FormCheckbox.vue` (+41 -0) 📝 `frontend/src/components/input/FormField.test.ts` (+60 -1) 📝 `frontend/src/components/input/FormField.vue` (+73 -33) ➕ `frontend/src/components/input/FormInput.test.ts` (+123 -0) ➕ `frontend/src/components/input/FormInput.vue` (+78 -0) ➕ `frontend/src/components/input/FormSelect.test.ts` (+175 -0) ➕ `frontend/src/components/input/FormSelect.vue` (+100 -0) 📝 `frontend/src/components/misc/WebhookManager.vue` (+28 -48) 📝 `frontend/src/views/user/Login.vue` (+5 -10) 📝 `frontend/src/views/user/settings/General.vue` (+255 -396) </details> ### 📄 Description Introduces `FormInput`, `FormSelect`, and `FormCheckbox` primitives alongside a reshaped `FormField` (now supporting a `two-col` layout) so settings pages stop hand-rolling Bulma `.field`/`.control`/`.input`/`.select` markup — making a future Bulma removal a scoped, per-primitive change. Migrates: `General.vue` (31 fields), `WebhookManager.vue`, and the remember-me checkbox on `Login.vue`. `ApiTokens.vue`, `EditTeam.vue`, `Register.vue`, and `PasswordReset.vue` either already use `FormField` or contain only composite layouts that don't fit the primitives cleanly; left for the follow-up migration. ## Test plan - Open **Settings → General** and verify every row renders, inputs/selects/checkboxes work, and saving persists. - Open a project's **Webhooks** and exercise the create form (target URL, secret, basic-auth toggle). - Log in with "remember me" toggled on. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:12:22 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8418
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?