[PR #2633] [MERGED] refactor(frontend): detach Modal.vue from Bulma's modal partial #8417

New Issue

2026-04-20T18:12:20-05:00

GiteaMirror commented

2026-04-20 18:12:20 -05:00

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2633
Author: @tink-bot
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/15/2026
Merged by: @kolaente

Base: main ← Head: fix-modal-detach-bulma

📝 Commits (3)

752918e refactor(frontend): inline modal-card-head-padding in Card footer
4e6c7d7 refactor(frontend): inline modal-content-spacing-tablet in PDF preview
be7ed7d refactor(frontend): drop unused Bulma modal partial import

📊 Changes

3 files changed (+3 additions, -3 deletions)

View changed files

📝 frontend/src/components/misc/Card.vue (+1 -1)
📝 frontend/src/components/tasks/partials/Attachments.vue (+1 -1)
📝 frontend/src/styles/global.scss (+1 -1)

📄 Description

Modal.vue has used a native <dialog> element with its own locally-scoped class names for a while, so Bulma's components/modal partial was effectively dead code. This removes it and inlines the two CSS variables (--modal-card-head-padding, --modal-content-spacing-tablet) that still had callers — both with Bulma's defaults, so no visual change is intended.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2633 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/15/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-modal-detach-bulma` --- ### 📝 Commits (3) - [`752918e`](https://github.com/go-vikunja/vikunja/commit/752918e6811c72c7d13f6f41b95f23e7d76b1d2c) refactor(frontend): inline modal-card-head-padding in Card footer - [`4e6c7d7`](https://github.com/go-vikunja/vikunja/commit/4e6c7d77fb097171cb281573f8ed3f6e13eaf37b) refactor(frontend): inline modal-content-spacing-tablet in PDF preview - [`be7ed7d`](https://github.com/go-vikunja/vikunja/commit/be7ed7d37b689e6166014453e94d23e5d0660972) refactor(frontend): drop unused Bulma modal partial import ### 📊 Changes **3 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/misc/Card.vue` (+1 -1) 📝 `frontend/src/components/tasks/partials/Attachments.vue` (+1 -1) 📝 `frontend/src/styles/global.scss` (+1 -1) </details> ### 📄 Description Modal.vue has used a native `<dialog>` element with its own locally-scoped class names for a while, so Bulma's `components/modal` partial was effectively dead code. This removes it and inlines the two CSS variables (`--modal-card-head-padding`, `--modal-content-spacing-tablet`) that still had callers — both with Bulma's defaults, so no visual change is intended. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-20 18:12:20 -05:00

GiteaMirror closed this issue

2026-04-20 18:12:21 -05:00

Sign in to join this conversation.

Branches Tags

main

renovate/github.com-gabriel-vasile-mimetype-1.x

renovate/major-dev-dependencies

fix-migration-index-wipe

fix-sr-findings

pr-swarm-assets

claude/task-event-field-changes-ws73g2

feat-mcp

feat-audit-sinks

claude/per-user-feature-toggles-vqlg8x

docs-v2-query-param

feat-project-templates

claude/veans-question-xBFkq

spike-huma-openapi3

claude/investigate-swagger3-support-nyyUa

feat-list-view-buckets

ci-mysql-8-test

codex/analyze-codebase-for-email-task-feature

csv-import-feature

claude/email-reply-comments-wpdcQ

fix-oidc-pkce-support

fix/overview-subtasks-expand

feat/bucket-select-task-detail

feat-soft-delete-projects

claude/review-bot-design-plan-cf5C3

claude/project-scoped-api-tokens-KTqR3

claude/explore-openclaw-integration-KQEzg

claude/project-scoped-api-tokens-yv5KS

fix-duplicate-close-button

feat-list-view-sorting

feat/official-vite-sentry-plugin

feat/highlight-overdue-tasks

feat/add-enter-key-form-submission-handling

feat/TipTap-nits

feat/update-caldavtimetotimestamp-parsing

feat-phosphor-icons

wip-plans

claude/investigate-issue-2173-llKme

fix-description-text-drag

feat-custom-keyboard-shortcuts

pr-1845-ci

codex/fix-drag-and-drop-behavior-inconsistency

copilot/add-clickable-labels-for-filtering

copilot/fix-issue-1786

playwright-migration

fix-kanban-repeating-wip

copilot/fix-1498

feature/replace-axios

codex/upgrade-to-tailwind-4.1.8-using-pnpm

codex/add-cypress-test-for-avatar-types

feature/biome

feature/oxc

codex/update-flexsearch-to-0.8.205

4r6ni9-codex/fix-deprecated-sass-@import-usage

codex/fix-deprecated-sass-@import-usage

codex/add-cypress-test-for-task-list-refresh-fix

codex/fix-quick-add-magic-not-adding-tasks

codex/fix-all-type-errors

codex/fix-mimetype-for-docs.json

feature/caldav-from-scratch

feature/gh-actions-hetzner

fix-ci

feat/new-logger

jyte-better-dev-config

feat/add-team-member-with-enter

fix/button-and-icon-types

fix/notifications-component-name-collision

feature/null-time

renovate/tailwindcss-4.x

feature/unplugin-vue-router

fix/deprecated-import

feature/zod-schema

renovate/golangci-golangci-lint-1.x

fix/tiptap-editor-reactive-destructuring

release/0.24

feat/improve-add-task

fix/saved-filter-search

feat/webp-and-avif-attachment-previews

feature/migrate-back-to-bulma

fix/sass-add-missing-list-import

feature/sticky-demo-bar

fix/gantt-view-switch

feature/typesense-position-join

feature/focus-visible

dependencies/golangci-lint

feature/better-filter-syntax

fix/tiptap-task-list

renovate/github.com-golang-jwt-jwt-v4-5.x

feature/hide-forbidden-related-tasks

renovate/golang-1.x

release/0.20

release/0.17

release/0.16

release/0.15

release/0.14

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/vikunja#8417