github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-07 03:58:09 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2626] [MERGED] fix(frontend): render editor popups inside modal dialog top-layer #8411

New Issue
Closed
opened 2026-04-20 18:12:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:12:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2626
Author: @tink-bot
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/15/2026
Merged by: @kolaente

Base: main ← Head: fix-mention-popup-dialog

📝 Commits (1)

  • 22af7c8 fix(frontend): render editor popups inside modal dialog top-layer

📊 Changes

3 files changed (+18 additions, -4 deletions)

View changed files

📝 frontend/src/components/input/editor/mention/mentionSuggestion.ts (+4 -2)
➕ frontend/src/components/input/editor/popupContainer.ts (+11 -0)
📝 frontend/src/components/input/editor/suggestion.ts (+3 -2)

📄 Description

Slash-command menu and user mention suggestions rendered behind the task detail modal because the task modal uses a native <dialog> with showModal() (top-layer), while popups were appended to document.body and couldn't paint above the top-layer regardless of z-index.

Fixes #2625

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2626 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/15/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-mention-popup-dialog` --- ### 📝 Commits (1) - [`22af7c8`](https://github.com/go-vikunja/vikunja/commit/22af7c85d3e1c1c6f38effc5c80ceb6db2e549e6) fix(frontend): render editor popups inside modal dialog top-layer ### 📊 Changes **3 files changed** (+18 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/editor/mention/mentionSuggestion.ts` (+4 -2) ➕ `frontend/src/components/input/editor/popupContainer.ts` (+11 -0) 📝 `frontend/src/components/input/editor/suggestion.ts` (+3 -2) </details> ### 📄 Description Slash-command menu and user mention suggestions rendered behind the task detail modal because the task modal uses a native `<dialog>` with `showModal()` (top-layer), while popups were appended to `document.body` and couldn't paint above the top-layer regardless of z-index. Fixes #2625 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:12:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8411
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?