github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 12:57:52 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2606] [MERGED] fix(auth): tolerate string booleans in oidc provider config #8397

New Issue
Closed
opened 2026-04-20 18:11:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:11:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2606
Author: @tink-bot
Created: 4/11/2026
Status: ✅ Merged
Merged: 4/11/2026
Merged by: @kolaente

Base: main ← Head: fix-2599-oidc-env-bool

📝 Commits (2)

  • 11e9d2e test(auth): cover env-var string booleans for oidc providers (#2599)
  • b480eaf fix(auth): tolerate string booleans in oidc provider config (#2599)

📊 Changes

2 files changed (+138 additions, -34 deletions)

View changed files

📝 pkg/modules/auth/openid/providers.go (+34 -34)
📝 pkg/modules/auth/openid/providers_test.go (+104 -0)

📄 Description

The four OIDC provider boolean fields (emailfallback, usernamefallback, forceuserinfo, requireavailability) were parsed with a strict .(bool) type assertion, which fails whenever config arrives as strings — i.e. from environment variables or the *.file Docker secret convention (both flow through GetConfigValueFromFile which always returns strings). requireavailability is the one #2599 reports.

Extract a small parseBoolField helper that accepts both native bools and strings via strconv.ParseBool.

Bonus fix: the same bug was silently dropping stringified emailfallback / usernamefallback values with no log at all — those two call sites had no else branch. They now log a parse error from the shared helper's code path, matching the other two fields.

Fixes #2599

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2606 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/11/2026 **Status:** ✅ Merged **Merged:** 4/11/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-2599-oidc-env-bool` --- ### 📝 Commits (2) - [`11e9d2e`](https://github.com/go-vikunja/vikunja/commit/11e9d2e085a28e7ca62d37595af6ff676f8b811b) test(auth): cover env-var string booleans for oidc providers (#2599) - [`b480eaf`](https://github.com/go-vikunja/vikunja/commit/b480eafd2909675e925a1b65b6fbb4bbfcb17a1f) fix(auth): tolerate string booleans in oidc provider config (#2599) ### 📊 Changes **2 files changed** (+138 additions, -34 deletions) <details> <summary>View changed files</summary> 📝 `pkg/modules/auth/openid/providers.go` (+34 -34) 📝 `pkg/modules/auth/openid/providers_test.go` (+104 -0) </details> ### 📄 Description The four OIDC provider boolean fields (`emailfallback`, `usernamefallback`, `forceuserinfo`, `requireavailability`) were parsed with a strict `.(bool)` type assertion, which fails whenever config arrives as strings — i.e. from environment variables or the `*.file` Docker secret convention (both flow through `GetConfigValueFromFile` which always returns strings). `requireavailability` is the one #2599 reports. Extract a small `parseBoolField` helper that accepts both native bools and strings via `strconv.ParseBool`. **Bonus fix:** the same bug was silently dropping stringified `emailfallback` / `usernamefallback` values with no log at all — those two call sites had no `else` branch. They now log a parse error from the shared helper's code path, matching the other two fields. Fixes #2599 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:11:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8397
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?