github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 10:41:50 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2588] [MERGED] fix: Backend hard coded api base #8388

New Issue
Closed
opened 2026-04-20 18:11:24 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:11:24 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2588
Author: @mdrkrg
Created: 4/10/2026
Status: ✅ Merged
Merged: 4/20/2026
Merged by: @kolaente

Base: main ← Head: fix/backend-hard-coded-api-base

📝 Commits (4)

  • 7c374e3 fix(auth): Make refresh token path respect to public URL
  • 5edf62e fix(api/docs): Make redoc load docs.json from public URL
  • e9a9807 fix(auth): Cleanup getRefreshTokenCookiePath implementation
  • 29ac1e2 fix(api/docs): Use Base in redoc template

📊 Changes

3 files changed (+38 additions, -7 deletions)

View changed files

📝 pkg/modules/auth/auth.go (+19 -3)
📝 pkg/routes/api/v1/docs.go (+17 -2)
📝 pkg/routes/api/v1/redoc/redoc.html (+2 -2)

📄 Description

Porting stale changes from #2436, this mainly focus on the backend.

Resolves https://github.com/go-vikunja/vikunja/issues/2657

What changed

  • auth/auth.go: Compute refresh token cookie base path from service.publicurl rather than hard coding the base as /api/v1.
  • api/v1/docs.go: Build redocHTML as template, and replace with apiBase + api/v1/docs.json and apiBase + api/v1/docs/redoc.standalone.js.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2588 **Author:** [@mdrkrg](https://github.com/mdrkrg) **Created:** 4/10/2026 **Status:** ✅ Merged **Merged:** 4/20/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/backend-hard-coded-api-base` --- ### 📝 Commits (4) - [`7c374e3`](https://github.com/go-vikunja/vikunja/commit/7c374e348520a79f811287be8eae9089474a291f) fix(auth): Make refresh token path respect to public URL - [`5edf62e`](https://github.com/go-vikunja/vikunja/commit/5edf62e6f07e099f62e7e3dcedf8eb57700ffdeb) fix(api/docs): Make redoc load docs.json from public URL - [`e9a9807`](https://github.com/go-vikunja/vikunja/commit/e9a9807ecea5037fa6647af7030dad15c329ad10) fix(auth): Cleanup getRefreshTokenCookiePath implementation - [`29ac1e2`](https://github.com/go-vikunja/vikunja/commit/29ac1e28f3de10a2f67e92bf33738fb436e3e21e) fix(api/docs): Use Base in redoc template ### 📊 Changes **3 files changed** (+38 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/modules/auth/auth.go` (+19 -3) 📝 `pkg/routes/api/v1/docs.go` (+17 -2) 📝 `pkg/routes/api/v1/redoc/redoc.html` (+2 -2) </details> ### 📄 Description Porting stale changes from #2436, this mainly focus on the backend. Resolves https://github.com/go-vikunja/vikunja/issues/2657 ## What changed - `auth/auth.go`: Compute refresh token cookie base path from `service.publicurl` rather than hard coding the base as `/api/v1`. - `api/v1/docs.go`: Build `redocHTML` as template, and replace with `apiBase + api/v1/docs.json` and `apiBase + api/v1/docs/redoc.standalone.js`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:11:24 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?