github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 12:57:52 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2566] [MERGED] fix: prevent HTTP 500 on task position conflicts and SQLite expression depth limit #8369

New Issue
Closed
opened 2026-04-20 18:10:41 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:10:41 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2566
Author: @tink-bot
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @kolaente

Base: main ← Head: fix-position-repair-error

📝 Commits (3)

  • e690e25 fix: catch ErrNeedsFullRecalculation in task creation position conflict resolution
  • 8812c17 fix: batch delete conditions in filter view cron to avoid SQLite expression depth limit
  • b747cf4 refactor: use per-view IN clause for filter task deletion instead of batching

📊 Changes

3 files changed (+90 additions, -21 deletions)

View changed files

📝 pkg/models/saved_filters.go (+27 -21)
📝 pkg/models/task_position.go (+17 -0)
📝 pkg/models/task_position_test.go (+46 -0)

📄 Description

Two independent bugs caused errors during task creation and in the filter view cron job when position data grew large enough to trigger edge cases.

  1. resolvePositionConflictsAfterInsert() now catches ErrNeedsFullRecalculation and falls back to a full position recalculation (mirroring the existing CLI repair command pattern) instead of bubbling up as HTTP 500.
  2. upsertRelatedTaskProperties() now batches builder.Or(deleteCond...) into chunks of 500 to stay under SQLite's 1000-node expression depth limit.

Fixes #2550

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2566 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-position-repair-error` --- ### 📝 Commits (3) - [`e690e25`](https://github.com/go-vikunja/vikunja/commit/e690e25ffa1b4cbe54c310ee5c8d8bf1294aef7e) fix: catch ErrNeedsFullRecalculation in task creation position conflict resolution - [`8812c17`](https://github.com/go-vikunja/vikunja/commit/8812c1768495de14297abc06614e57e7ffc1a9b0) fix: batch delete conditions in filter view cron to avoid SQLite expression depth limit - [`b747cf4`](https://github.com/go-vikunja/vikunja/commit/b747cf4a7c2e0af5b6976b1b40858be4af9850e3) refactor: use per-view IN clause for filter task deletion instead of batching ### 📊 Changes **3 files changed** (+90 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/saved_filters.go` (+27 -21) 📝 `pkg/models/task_position.go` (+17 -0) 📝 `pkg/models/task_position_test.go` (+46 -0) </details> ### 📄 Description Two independent bugs caused errors during task creation and in the filter view cron job when position data grew large enough to trigger edge cases. 1. `resolvePositionConflictsAfterInsert()` now catches `ErrNeedsFullRecalculation` and falls back to a full position recalculation (mirroring the existing CLI repair command pattern) instead of bubbling up as HTTP 500. 2. `upsertRelatedTaskProperties()` now batches `builder.Or(deleteCond...)` into chunks of 500 to stay under SQLite's 1000-node expression depth limit. Fixes #2550 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:10:41 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?