github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2565] [MERGED] fix: reset SSO avatar provider to default when picture claim is removed #8368

New Issue
Closed
opened 2026-04-20 18:10:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:10:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2565
Author: @tink-bot
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @kolaente

Base: main ← Head: fix-avatar-sso-reset

📝 Commits (4)

  • 49a366e test: add tests for SSO avatar provider reset on empty picture URL
  • 45031ff fix: reset SSO avatar provider to default when picture claim is removed
  • cadb793 fix: use assert.Empty instead of assert.Equal for empty string check
  • ce1f412 fix: update user list test expectations for new fixture user

📊 Changes

4 files changed (+68 additions, -4 deletions)

View changed files

📝 pkg/db/fixtures/users.yml (+10 -0)
📝 pkg/models/user_list_test.go (+2 -2)
📝 pkg/modules/auth/openid/openid.go (+10 -2)
📝 pkg/modules/auth/openid/openid_test.go (+46 -0)

📄 Description

When a user removes their profile picture from their OpenID Connect identity provider, Vikunja kept the avatar provider set to "openid", resulting in a broken avatar. This resets it to "default" when the OIDC picture claim is empty, while respecting manually chosen providers like gravatar or upload.

Relates to #2217

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2565 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-avatar-sso-reset` --- ### 📝 Commits (4) - [`49a366e`](https://github.com/go-vikunja/vikunja/commit/49a366e7c44a9671aa49bcfc405fb2422c962528) test: add tests for SSO avatar provider reset on empty picture URL - [`45031ff`](https://github.com/go-vikunja/vikunja/commit/45031ff5a73ceac253d5e8747657f22491198e87) fix: reset SSO avatar provider to default when picture claim is removed - [`cadb793`](https://github.com/go-vikunja/vikunja/commit/cadb793bbf5025520ff07f9c06042359f98e7099) fix: use assert.Empty instead of assert.Equal for empty string check - [`ce1f412`](https://github.com/go-vikunja/vikunja/commit/ce1f4121c7c0c535e458a19f16f9087230cbf095) fix: update user list test expectations for new fixture user ### 📊 Changes **4 files changed** (+68 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/db/fixtures/users.yml` (+10 -0) 📝 `pkg/models/user_list_test.go` (+2 -2) 📝 `pkg/modules/auth/openid/openid.go` (+10 -2) 📝 `pkg/modules/auth/openid/openid_test.go` (+46 -0) </details> ### 📄 Description When a user removes their profile picture from their OpenID Connect identity provider, Vikunja kept the avatar provider set to "openid", resulting in a broken avatar. This resets it to "default" when the OIDC picture claim is empty, while respecting manually chosen providers like gravatar or upload. Relates to #2217 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:10:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8368
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?