github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2537] [MERGED] fix: use recursive CTE in accessibleProjectIDsSubquery for inherited project permissions #8347

New Issue
Closed
opened 2026-04-20 18:09:55 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:09:55 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2537
Author: @tink-bot
Created: 4/3/2026
Status: ✅ Merged
Merged: 4/5/2026
Merged by: @kolaente

Base: main ← Head: fix-subtask-permission-hierarchy

📝 Commits (1)

  • 7eb2617 fix: use recursive CTE in accessibleProjectIDsSubquery for inherited project permissions

📊 Changes

10 files changed (+209 additions, -7 deletions)

View changed files

📝 pkg/db/fixtures/project_views.yml (+50 -0)
📝 pkg/db/fixtures/projects.yml (+21 -0)
📝 pkg/db/fixtures/task_relations.yml (+13 -0)
📝 pkg/db/fixtures/tasks.yml (+18 -0)
📝 pkg/db/fixtures/team_members.yml (+3 -0)
📝 pkg/db/fixtures/team_projects.yml (+7 -0)
📝 pkg/db/fixtures/teams.yml (+3 -0)
📝 pkg/models/project.go (+23 -6)
📝 pkg/models/project_test.go (+1 -1)
📝 pkg/models/task_relation_authz_test.go (+70 -0)

📄 Description

Users with team access on a parent project could not see subtask relations for tasks in child projects, because accessibleProjectIDsSubquery() used a non-recursive query that only returned directly accessible projects.

The fix wraps the base query in a recursive CTE that walks child projects via parent_project_id, matching the permission model already used in getAllProjectsForUser().

Fixes #2490

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2537 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/3/2026 **Status:** ✅ Merged **Merged:** 4/5/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-subtask-permission-hierarchy` --- ### 📝 Commits (1) - [`7eb2617`](https://github.com/go-vikunja/vikunja/commit/7eb26176f8783f5f88992237ccefcc4c599674d5) fix: use recursive CTE in accessibleProjectIDsSubquery for inherited project permissions ### 📊 Changes **10 files changed** (+209 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/db/fixtures/project_views.yml` (+50 -0) 📝 `pkg/db/fixtures/projects.yml` (+21 -0) 📝 `pkg/db/fixtures/task_relations.yml` (+13 -0) 📝 `pkg/db/fixtures/tasks.yml` (+18 -0) 📝 `pkg/db/fixtures/team_members.yml` (+3 -0) 📝 `pkg/db/fixtures/team_projects.yml` (+7 -0) 📝 `pkg/db/fixtures/teams.yml` (+3 -0) 📝 `pkg/models/project.go` (+23 -6) 📝 `pkg/models/project_test.go` (+1 -1) 📝 `pkg/models/task_relation_authz_test.go` (+70 -0) </details> ### 📄 Description Users with team access on a parent project could not see subtask relations for tasks in child projects, because `accessibleProjectIDsSubquery()` used a non-recursive query that only returned directly accessible projects. The fix wraps the base query in a recursive CTE that walks child projects via `parent_project_id`, matching the permission model already used in `getAllProjectsForUser()`. Fixes #2490 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:09:55 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8347
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?