github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2446] [MERGED] fix: check child project's own IsArchived flag in CheckIsArchived #8274

New Issue
Closed
opened 2026-04-20 18:07:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:07:35 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2446
Author: @tink-bot
Created: 3/23/2026
Status: ✅ Merged
Merged: 3/23/2026
Merged by: @kolaente

Base: main ← Head: fix/check-is-archived-child-project

📝 Commits (2)

  • 83840df fix: check child project's own IsArchived flag in CheckIsArchived
  • c797fc3 fix: update ParadeDB search test count for new fixture

📊 Changes

4 files changed (+74 additions, -10 deletions)

View changed files

📝 pkg/db/fixtures/projects.yml (+13 -0)
📝 pkg/models/project.go (+11 -6)
📝 pkg/models/project_test.go (+49 -3)
📝 pkg/webtests/project_test.go (+1 -1)

📄 Description

CheckIsArchived() skipped checking a child project's own IsArchived flag when ParentProjectID > 0, immediately recursing to only check the parent. This allowed all write operations (task creation, updates, deletions, label/assignee/comment operations) on individually archived child projects whose parent was not archived.

Additionally fixes variable shadowing that prevented multi-level parent checking and ensures new projects (ID=0) still validate their parent's archived state.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2446 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 3/23/2026 **Status:** ✅ Merged **Merged:** 3/23/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/check-is-archived-child-project` --- ### 📝 Commits (2) - [`83840df`](https://github.com/go-vikunja/vikunja/commit/83840df422ce6c5c3852c47c8c7d97cee6b51204) fix: check child project's own IsArchived flag in CheckIsArchived - [`c797fc3`](https://github.com/go-vikunja/vikunja/commit/c797fc32662f042141506a2888c26c16d0609798) fix: update ParadeDB search test count for new fixture ### 📊 Changes **4 files changed** (+74 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `pkg/db/fixtures/projects.yml` (+13 -0) 📝 `pkg/models/project.go` (+11 -6) 📝 `pkg/models/project_test.go` (+49 -3) 📝 `pkg/webtests/project_test.go` (+1 -1) </details> ### 📄 Description `CheckIsArchived()` skipped checking a child project's own `IsArchived` flag when `ParentProjectID > 0`, immediately recursing to only check the parent. This allowed all write operations (task creation, updates, deletions, label/assignee/comment operations) on individually archived child projects whose parent was not archived. Additionally fixes variable shadowing that prevented multi-level parent checking and ensures new projects (ID=0) still validate their parent's archived state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:07:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?