github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2320] [MERGED] fix: use MinPositionSpacing threshold in calculateNewPositionForTask #8187

New Issue
Closed
opened 2026-04-20 18:04:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:04:38 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2320
Author: @maggch97
Created: 2/28/2026
Status: ✅ Merged
Merged: 3/2/2026
Merged by: @kolaente

Base: main ← Head: fix/task-position-min-spacing

📝 Commits (2)

  • 3b61b58 fix: use MinPositionSpacing threshold in calculateNewPositionForTask
  • 3f4bdf2 fix: use local variable for position to avoid cross-view contamination

📊 Changes

1 file changed (+5 additions, -4 deletions)

View changed files

📝 pkg/models/task_position.go (+5 -4)

📄 Description

calculateNewPositionForTask only checked for lowestPosition == 0 before triggering a full position recalculation. Extremely small position values (e.g. 3.16e-285) passed this check, causing new tasks to get meaningless positions via the index * 2^16 fallback, breaking sort order.

Use the same < MinPositionSpacing threshold that createPositionsForTasksInView and the position update handler already use.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2320 **Author:** [@maggch97](https://github.com/maggch97) **Created:** 2/28/2026 **Status:** ✅ Merged **Merged:** 3/2/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/task-position-min-spacing` --- ### 📝 Commits (2) - [`3b61b58`](https://github.com/go-vikunja/vikunja/commit/3b61b58bd809df4fffce342244d6c5aac69edb53) fix: use MinPositionSpacing threshold in calculateNewPositionForTask - [`3f4bdf2`](https://github.com/go-vikunja/vikunja/commit/3f4bdf2a254e7bfa7f9b2e6f00c3de02ff5ae5ea) fix: use local variable for position to avoid cross-view contamination ### 📊 Changes **1 file changed** (+5 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/task_position.go` (+5 -4) </details> ### 📄 Description calculateNewPositionForTask only checked for lowestPosition == 0 before triggering a full position recalculation. Extremely small position values (e.g. 3.16e-285) passed this check, causing new tasks to get meaningless positions via the index * 2^16 fallback, breaking sort order. Use the same < MinPositionSpacing threshold that createPositionsForTasksInView and the position update handler already use. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:04:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8187
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?