github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2288] [MERGED] fix: resolve upgrade migration issues for v0.24.6 -> v1.x upgrades #8163

New Issue
Closed
opened 2026-04-20 18:04:03 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:04:03 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2288
Author: @kolaente
Created: 2/24/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @kolaente

Base: main ← Head: fix-upgrade-migration-issues

📝 Commits (5)

  • 9dc9f05 fix: replace tx.Sync() with explicit ALTER TABLE in webhooks migration
  • 1ae94d7 fix: make teams oidc_id rename migration idempotent
  • 614a342 fix: add comprehensive catchup for bucket and filter format migrations
  • 6e9ed4a fix: cast bucket_configuration to text in postgres catchup query
  • b4ccff5 fix: preserve teams external_id type when renaming on mysql

📊 Changes

4 files changed (+364 additions, -12 deletions)

View changed files

📝 pkg/migration/20250317174522.go (+32 -2)
📝 pkg/migration/20260123000717.go (+16 -10)
➕ pkg/migration/20260224122023.go (+213 -0)
➕ pkg/migration/20260224122023_test.go (+103 -0)

📄 Description

Summary

This PR fixes several migration and upgrade-path issues affecting upgrades from v0.24.6 to v1.0.0/v1.1.0.

Changes included:

  • replace tx.Sync() in the webhooks basic-auth migration with explicit ALTER TABLE ADD COLUMN statements (with existence checks)
  • make the teams oidc_id -> external_id rename migration idempotent (including SQLite handling)
  • add a comprehensive catchup migration that converts legacy bucket_configuration and view-level filter formats regardless of bucket_configuration_mode
  • add focused regression tests for bucket filter conversion helper logic in the new catchup migration

Issues Fixed / Addressed

Validation

  • mage build
  • mage test:filter TestConvertBucketConfigurations20260224122023
  • mage test:web
  • mage test:feature

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2288 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/24/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-upgrade-migration-issues` --- ### 📝 Commits (5) - [`9dc9f05`](https://github.com/go-vikunja/vikunja/commit/9dc9f051f99bb5a95cddcefe2fedbaf5f30a6190) fix: replace tx.Sync() with explicit ALTER TABLE in webhooks migration - [`1ae94d7`](https://github.com/go-vikunja/vikunja/commit/1ae94d7c0e44472f625f6f8e9357f95bc7f52d8a) fix: make teams oidc_id rename migration idempotent - [`614a342`](https://github.com/go-vikunja/vikunja/commit/614a342100bc14ecba972c740a9e6f28b4ea2d2c) fix: add comprehensive catchup for bucket and filter format migrations - [`6e9ed4a`](https://github.com/go-vikunja/vikunja/commit/6e9ed4a32a7e867a723dffeab4257474266282fd) fix: cast bucket_configuration to text in postgres catchup query - [`b4ccff5`](https://github.com/go-vikunja/vikunja/commit/b4ccff5a170b9c974413e839679ce3f79f552661) fix: preserve teams external_id type when renaming on mysql ### 📊 Changes **4 files changed** (+364 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `pkg/migration/20250317174522.go` (+32 -2) 📝 `pkg/migration/20260123000717.go` (+16 -10) ➕ `pkg/migration/20260224122023.go` (+213 -0) ➕ `pkg/migration/20260224122023_test.go` (+103 -0) </details> ### 📄 Description ## Summary This PR fixes several migration and upgrade-path issues affecting upgrades from `v0.24.6` to `v1.0.0`/`v1.1.0`. Changes included: - replace `tx.Sync()` in the webhooks basic-auth migration with explicit `ALTER TABLE ADD COLUMN` statements (with existence checks) - make the teams `oidc_id -> external_id` rename migration idempotent (including SQLite handling) - add a comprehensive catchup migration that converts legacy `bucket_configuration` and view-level `filter` formats regardless of `bucket_configuration_mode` - add focused regression tests for bucket filter conversion helper logic in the new catchup migration ## Issues Fixed / Addressed - Fixes #2172 - Fixes #2188 - Fixes #2202 - Fixes #2215 - Fixes #2285 ## Validation - `mage build` - `mage test:filter TestConvertBucketConfigurations20260224122023` - `mage test:web` - `mage test:feature` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:04:03 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?