github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2226] [MERGED] feat(auth): allow LDAP authentication with anonymous bind #8124

New Issue
Closed
opened 2026-04-20 18:03:08 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:03:08 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2226
Author: @Quiwy
Created: 2/11/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @kolaente

Base: main ← Head: feat/ldap-anonymous-bind

📝 Commits (1)

  • 044c160 feat: allow anonymous LDAP bind

📊 Changes

2 files changed (+42 additions, -10 deletions)

View changed files

📝 pkg/modules/auth/ldap/ldap.go (+11 -10)
📝 pkg/modules/auth/ldap/ldap_test.go (+31 -0)

📄 Description

As discussed on Matrix, Vikunja currently prevents users from using LDAP authentication if the server allows anonymous binds (common in local environments like YunoHost). The application would previously trigger a log.Fatal if AuthLdapBindDN or AuthLdapBindPassword were left empty in the configuration.

How this fixes the problem:

  • Validation: Removed the strict requirement for Bind credentials in InitializeLDAPConnection.
  • Connection Logic: Updated ConnectAndBindToLDAPDirectory to attempt an UnauthenticatedBind from the go-ldap library when no credentials are provided.
  • Safety: If a Bind DN is provided, the behavior remains unchanged (authenticated bind).

Testing:

  • Tested manually on a YunoHost instance by replacing the binary.
  • Confirmed that Vikunja now successfully starts and authenticates users via the local LDAP (localhost) without requiring a service account.
  • Added a basic unit test in pkg/modules/auth/ldap/ldap_test.go to ensure the initialization logic doesn't crash with empty credentials.

Note: This is my first contribution to a Go project (assisted by an LLM for syntax). Feedback on code style is more than welcome!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2226 **Author:** [@Quiwy](https://github.com/Quiwy) **Created:** 2/11/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `feat/ldap-anonymous-bind` --- ### 📝 Commits (1) - [`044c160`](https://github.com/go-vikunja/vikunja/commit/044c16009b1458d469d8701be98cc7a06e3cadf9) feat: allow anonymous LDAP bind ### 📊 Changes **2 files changed** (+42 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `pkg/modules/auth/ldap/ldap.go` (+11 -10) 📝 `pkg/modules/auth/ldap/ldap_test.go` (+31 -0) </details> ### 📄 Description As discussed on Matrix, Vikunja currently prevents users from using LDAP authentication if the server allows anonymous binds (common in local environments like YunoHost). The application would previously trigger a `log.Fatal` if `AuthLdapBindDN` or `AuthLdapBindPassword` were left empty in the configuration. #### **How this fixes the problem:** * **Validation:** Removed the strict requirement for Bind credentials in `InitializeLDAPConnection`. * **Connection Logic:** Updated `ConnectAndBindToLDAPDirectory` to attempt an `UnauthenticatedBind` from the `go-ldap` library when no credentials are provided. * **Safety:** If a Bind DN is provided, the behavior remains unchanged (authenticated bind). #### **Testing:** * Tested manually on a **YunoHost** instance by replacing the binary. * Confirmed that Vikunja now successfully starts and authenticates users via the local LDAP (localhost) without requiring a service account. * Added a basic unit test in `pkg/modules/auth/ldap/ldap_test.go` to ensure the initialization logic doesn't crash with empty credentials. *Note: This is my first contribution to a Go project (assisted by an LLM for syntax). Feedback on code style is more than welcome!* --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:03:08 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8124
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?