github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2212] [MERGED] fix(task): require explicit confirmation before saving reminders #8119

New Issue
Closed
opened 2026-04-20 18:02:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:02:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2212
Author: @kolaente
Created: 2/9/2026
Status: ✅ Merged
Merged: 2/24/2026
Merged by: @kolaente

Base: main ← Head: fix-reminder-auto-submit

📝 Commits (4)

  • 2dc6a5a fix(task): require explicit confirmation before saving reminders
  • a5428df test(task): add e2e tests for reminder confirm-before-save behavior
  • 9946996 fix(test): update existing reminder tests to click Confirm after date selection
  • 5ac0386 fix(task): disable Confirm button when no date is selected in absolute reminder picker

📊 Changes

2 files changed (+81 additions, -7 deletions)

View changed files

📝 frontend/src/components/tasks/partials/ReminderDetail.vue (+12 -7)
📝 frontend/tests/e2e/task/task.spec.ts (+69 -0)

📄 Description

Currently, the reminder popup closes right after clicking on a date. This prevents users from actually setting a reminder time - they have to edit the reminder after adding it.

This PR changes that: Reminders are now not saved when clicking on the date, requiring users to click on the button below the time input to save the reminder.

Resolves #2208

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2212 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/9/2026 **Status:** ✅ Merged **Merged:** 2/24/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-reminder-auto-submit` --- ### 📝 Commits (4) - [`2dc6a5a`](https://github.com/go-vikunja/vikunja/commit/2dc6a5acb02fc37c19d5daa8f634b647d016e2ae) fix(task): require explicit confirmation before saving reminders - [`a5428df`](https://github.com/go-vikunja/vikunja/commit/a5428df3a5541505e00acb35c2d8d28ac21b45fa) test(task): add e2e tests for reminder confirm-before-save behavior - [`9946996`](https://github.com/go-vikunja/vikunja/commit/99469969b19767c06dbc0ef20a6a947424a71ee6) fix(test): update existing reminder tests to click Confirm after date selection - [`5ac0386`](https://github.com/go-vikunja/vikunja/commit/5ac0386910ce03a981b7a2b15e532ba6b0bbb02c) fix(task): disable Confirm button when no date is selected in absolute reminder picker ### 📊 Changes **2 files changed** (+81 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/ReminderDetail.vue` (+12 -7) 📝 `frontend/tests/e2e/task/task.spec.ts` (+69 -0) </details> ### 📄 Description Currently, the reminder popup closes right after clicking on a date. This prevents users from actually setting a reminder time - they have to edit the reminder after adding it. This PR changes that: Reminders are now not saved when clicking on the date, requiring users to click on the button below the time input to save the reminder. Resolves #2208 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:02:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?