github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-05 19:18:16 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2206] [MERGED] fix(log): write each log category to its own file #8116

New Issue
Closed
opened 2026-04-20 18:02:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:02:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2206
Author: @kolaente
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @kolaente

Base: main ← Head: fix-log-file-per-category

📝 Commits (3)

  • d5feb1c test: add failing test for per-category log file creation
  • 9c06625 fix(log): write each log category to its own file
  • ebf4f84 fix(log): write echo logger to http.log

📊 Changes

6 files changed (+35 additions, -8 deletions)

View changed files

📝 pkg/log/echo_logger.go (+1 -1)
📝 pkg/log/logging.go (+4 -4)
📝 pkg/log/logging_test.go (+27 -0)
📝 pkg/log/mail_logger.go (+1 -1)
📝 pkg/log/watermill_logger.go (+1 -1)
📝 pkg/log/xorm_logger.go (+1 -1)

📄 Description

Previously, makeLogHandler() hardcoded "standard" as the logfile name passed to getLogWriter(), causing all log categories (database, http, events, mail) to write to standard.log instead of their own files.

Add a logfile parameter to makeLogHandler() so each caller specifies its category name, producing database.log, http.log, echo.log, events.log, and mail.log as expected.

Fixes https://github.com/go-vikunja/vikunja/issues/2177

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2206 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-log-file-per-category` --- ### 📝 Commits (3) - [`d5feb1c`](https://github.com/go-vikunja/vikunja/commit/d5feb1cdb7424e7e1f811940c6c6cbcc5b8160d3) test: add failing test for per-category log file creation - [`9c06625`](https://github.com/go-vikunja/vikunja/commit/9c066258c5403c0d209d6f73c98fc99c9b42be63) fix(log): write each log category to its own file - [`ebf4f84`](https://github.com/go-vikunja/vikunja/commit/ebf4f843d6c0896d225db6a8f71212e628b6c97a) fix(log): write echo logger to http.log ### 📊 Changes **6 files changed** (+35 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `pkg/log/echo_logger.go` (+1 -1) 📝 `pkg/log/logging.go` (+4 -4) 📝 `pkg/log/logging_test.go` (+27 -0) 📝 `pkg/log/mail_logger.go` (+1 -1) 📝 `pkg/log/watermill_logger.go` (+1 -1) 📝 `pkg/log/xorm_logger.go` (+1 -1) </details> ### 📄 Description Previously, `makeLogHandler()` hardcoded "standard" as the logfile name passed to `getLogWriter()`, causing all log categories (`database`, `http`, `events`, `mail`) to write to `standard.log` instead of their own files. Add a logfile parameter to `makeLogHandler()` so each caller specifies its category name, producing `database.log`, `http.log`, `echo.log`, `events.log`, and `mail.log` as expected. Fixes https://github.com/go-vikunja/vikunja/issues/2177 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:02:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8116
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?