github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2204] [MERGED] fix: show user-visible errors when file attachment uploads fail #8114

New Issue
Closed
opened 2026-04-20 18:02:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:02:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2204
Author: @kolaente
Created: 2/8/2026
Status: ✅ Merged
Merged: 2/8/2026
Merged by: @kolaente

Base: main ← Head: fix-s3-upload-error-handling

📝 Commits (2)

  • a4ac22a fix: format attachment upload error messages as readable strings
  • 872928f fix: handle attachment upload errors with user-visible notifications

📊 Changes

2 files changed (+8 additions, -3 deletions)

View changed files

📝 frontend/src/components/tasks/partials/Attachments.vue (+6 -2)
📝 frontend/src/helpers/attachments.ts (+2 -1)

📄 Description

  • Fix error message formatting in uploadFiles() — the previous code passed an array of {code, message} objects to Error(), which coerced them to "[object Object]". Now extracts .message strings and joins them.
  • Add async/await and try/catch to uploadFilesToTask() in Attachments.vue so upload errors are caught and displayed as toast notifications via the existing error() helper.

Partially adresses https://github.com/go-vikunja/vikunja/issues/2181

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2204 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 2/8/2026 **Status:** ✅ Merged **Merged:** 2/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-s3-upload-error-handling` --- ### 📝 Commits (2) - [`a4ac22a`](https://github.com/go-vikunja/vikunja/commit/a4ac22a94e589955fa87f0920cd593b5dd425b1a) fix: format attachment upload error messages as readable strings - [`872928f`](https://github.com/go-vikunja/vikunja/commit/872928f5a9672a4f84ec5c64491b1d88f92a679e) fix: handle attachment upload errors with user-visible notifications ### 📊 Changes **2 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/Attachments.vue` (+6 -2) 📝 `frontend/src/helpers/attachments.ts` (+2 -1) </details> ### 📄 Description - Fix error message formatting in `uploadFiles()` — the previous code passed an array of `{code, message}` objects to `Error()`, which coerced them to `"[object Object]"`. Now extracts `.message` strings and joins them. - Add `async`/`await` and `try/catch` to `uploadFilesToTask()` in `Attachments.vue` so upload errors are caught and displayed as toast notifications via the existing `error()` helper. Partially adresses https://github.com/go-vikunja/vikunja/issues/2181 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:02:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8114
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?