github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 11:37:49 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2155] [MERGED] fix: use dark shadows for email template in dark mode #8098

New Issue
Closed
opened 2026-04-20 18:02:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 18:02:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2155
Author: @kolaente
Created: 1/25/2026
Status: ✅ Merged
Merged: 1/26/2026
Merged by: @kolaente

Base: main ← Head: fix-email-dark-mode-shadow

📝 Commits (1)

  • 4920ec4 fix: use dark shadows for email template in dark mode

📊 Changes

2 files changed (+83 additions, -187 deletions)

View changed files

📝 pkg/notifications/mail_render.go (+19 -2)
📝 pkg/notifications/mail_test.go (+64 -185)

📄 Description

Summary

  • Add CSS-based dark mode support to the notification email template
  • Add color-scheme meta tags for email client dark mode detection
  • Add @media (prefers-color-scheme: dark) query with shadow overrides for card and button elements
  • Light gray shadows (#e6e6e6) are overridden with dark shadows (rgba(0,0,0,0.3)) in dark mode

This eliminates the white/bright shadow appearance when viewing notification emails in dark mode email clients (Apple Mail, iOS Mail, Outlook.com, Gmail iOS).

Test plan

  • Build succeeds (mage build)
  • Tests pass (go test ./pkg/notifications/...)
  • Send test email and verify in dark mode email client

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2155 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/25/2026 **Status:** ✅ Merged **Merged:** 1/26/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-email-dark-mode-shadow` --- ### 📝 Commits (1) - [`4920ec4`](https://github.com/go-vikunja/vikunja/commit/4920ec4546953c9f1baa9b235337d40ba72e0388) fix: use dark shadows for email template in dark mode ### 📊 Changes **2 files changed** (+83 additions, -187 deletions) <details> <summary>View changed files</summary> 📝 `pkg/notifications/mail_render.go` (+19 -2) 📝 `pkg/notifications/mail_test.go` (+64 -185) </details> ### 📄 Description ## Summary - Add CSS-based dark mode support to the notification email template - Add `color-scheme` meta tags for email client dark mode detection - Add `@media (prefers-color-scheme: dark)` query with shadow overrides for card and button elements - Light gray shadows (`#e6e6e6`) are overridden with dark shadows (`rgba(0,0,0,0.3)`) in dark mode This eliminates the white/bright shadow appearance when viewing notification emails in dark mode email clients (Apple Mail, iOS Mail, Outlook.com, Gmail iOS). ## Test plan - [ ] Build succeeds (`mage build`) - [ ] Tests pass (`go test ./pkg/notifications/...`) - [ ] Send test email and verify in dark mode email client --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 18:02:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8098
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?