github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-16 06:42:23 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2067] [MERGED] fix: multiselect clear button now properly clears the value #8031

New Issue
Closed
opened 2026-04-20 17:59:49 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:59:49 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2067
Author: @kolaente
Created: 1/8/2026
Status: ✅ Merged
Merged: 1/8/2026
Merged by: @kolaente

Base: main ← Head: fix/2045-multiselect-clear-button

📝 Commits (3)

  • 1704aa4 fix: multiselect clear button now properly clears the value
  • 50f81fc fix: ProjectSearch now properly handles clearing the value
  • 391b1c5 fix: timezone setter now handles null when clearing

📊 Changes

3 files changed (+16 additions, -5 deletions)

View changed files

📝 frontend/src/components/input/Multiselect.vue (+7 -0)
📝 frontend/src/components/tasks/partials/ProjectSearch.vue (+1 -1)
📝 frontend/src/views/user/settings/General.vue (+8 -4)

📄 Description

Summary

  • Fixed the clear button (X) in Multiselect component not clearing the selected value
  • The select function had an early return when null was passed, which prevented the clear action from working
  • Now properly clears internal value, query text, and emits update:modelValue with null

Fixes #2045

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2067 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/8/2026 **Status:** ✅ Merged **Merged:** 1/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix/2045-multiselect-clear-button` --- ### 📝 Commits (3) - [`1704aa4`](https://github.com/go-vikunja/vikunja/commit/1704aa4a7fe979aa236917a499847c19cae305af) fix: multiselect clear button now properly clears the value - [`50f81fc`](https://github.com/go-vikunja/vikunja/commit/50f81fcd64f1fa7255ff19eca71c0db7728c55fb) fix: ProjectSearch now properly handles clearing the value - [`391b1c5`](https://github.com/go-vikunja/vikunja/commit/391b1c5d4a7de342f88ee78d387f329285238649) fix: timezone setter now handles null when clearing ### 📊 Changes **3 files changed** (+16 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/input/Multiselect.vue` (+7 -0) 📝 `frontend/src/components/tasks/partials/ProjectSearch.vue` (+1 -1) 📝 `frontend/src/views/user/settings/General.vue` (+8 -4) </details> ### 📄 Description ## Summary - Fixed the clear button (X) in Multiselect component not clearing the selected value - The `select` function had an early return when null was passed, which prevented the clear action from working - Now properly clears internal value, query text, and emits `update:modelValue` with null Fixes #2045 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:59:49 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8031
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?