github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2053] [MERGED] feat(files): validate file storage is writable on startup #8020

New Issue
Closed
opened 2026-04-20 17:59:23 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:59:23 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2053
Author: @kolaente
Created: 1/5/2026
Status: ✅ Merged
Merged: 1/6/2026
Merged by: @kolaente

Base: main ← Head: feat-file-writable-startup-validation

📝 Commits (4)

  • 6a0c00a feat(files): validate file storage is writable on startup
  • c236b6a fix(files): fix tests for file storage validation
  • 91b8fb5 remove comment
  • 723ca96 remove more comments

📊 Changes

3 files changed (+56 additions, -19 deletions)

View changed files

📝 pkg/files/filehandling.go (+31 -2)
📝 pkg/files/files.go (+13 -14)
📝 pkg/files/s3_test.go (+12 -3)

📄 Description

Summary

  • Adds startup validation that checks if the configured file storage is writable
  • Creates and removes a temporary .vikunja-check-{timestamp} file during InitFileHandler()
  • Fails startup with a clear error if storage is not writable

Changes

  • Extract writeToStorage() internal function from Save() for reuse
  • Add ValidateFileStorage() function to test storage writability
  • Call validation after backend initialization in InitFileHandler()

Test plan

  • Start Vikunja with valid local storage path - should start normally
  • Start Vikunja with read-only local storage path - should fail with clear error
  • Start Vikunja with valid S3 configuration - should start normally
  • Start Vikunja with invalid S3 credentials - should fail with clear error

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2053 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 1/5/2026 **Status:** ✅ Merged **Merged:** 1/6/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `feat-file-writable-startup-validation` --- ### 📝 Commits (4) - [`6a0c00a`](https://github.com/go-vikunja/vikunja/commit/6a0c00a41db3678ff86b281b7fa67a2e70988102) feat(files): validate file storage is writable on startup - [`c236b6a`](https://github.com/go-vikunja/vikunja/commit/c236b6a85121f06cb833fb7182f25f52ef87b528) fix(files): fix tests for file storage validation - [`91b8fb5`](https://github.com/go-vikunja/vikunja/commit/91b8fb5abe2dc3b2860cbbdb91bcc645b2df2211) remove comment - [`723ca96`](https://github.com/go-vikunja/vikunja/commit/723ca96df46c1e06e3961cc323143bb4be451a8f) remove more comments ### 📊 Changes **3 files changed** (+56 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `pkg/files/filehandling.go` (+31 -2) 📝 `pkg/files/files.go` (+13 -14) 📝 `pkg/files/s3_test.go` (+12 -3) </details> ### 📄 Description ## Summary - Adds startup validation that checks if the configured file storage is writable - Creates and removes a temporary `.vikunja-check-{timestamp}` file during `InitFileHandler()` - Fails startup with a clear error if storage is not writable ## Changes - Extract `writeToStorage()` internal function from `Save()` for reuse - Add `ValidateFileStorage()` function to test storage writability - Call validation after backend initialization in `InitFileHandler()` ## Test plan - [ ] Start Vikunja with valid local storage path - should start normally - [ ] Start Vikunja with read-only local storage path - should fail with clear error - [ ] Start Vikunja with valid S3 configuration - should start normally - [ ] Start Vikunja with invalid S3 credentials - should fail with clear error --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:59:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8020
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?