github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2030] [CLOSED] fix(frontend): prevent saved filters from appearing twice in sidebar #8006

New Issue
Closed
opened 2026-04-20 17:58:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:58:51 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2030
Author: @IAMSamuelRodda
Created: 12/28/2025
Status: ❌ Closed

Base: main ← Head: fix/saved-filters-duplicate

📝 Commits (1)

  • 71af44a fix(frontend): prevent saved filters from appearing twice in sidebar

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 frontend/src/stores/projects.ts (+1 -1)

📄 Description

Summary

  • Saved filters were appearing in both the Favorites section and the Filters section when marked as favorite
  • This occurred because favoriteProjects included all items with isFavorite: true, regardless of whether they were actual projects or saved filters (which have negative IDs)
  • Added a check for positive IDs (p.id > 0) to exclude saved filters from the favorites list

Test plan

  • Mark a saved filter as favorite
  • Verify the filter appears only once in the sidebar (in the Filters section)
  • Verify regular projects still appear correctly in Favorites when marked as favorite

Fixes #1989

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2030 **Author:** [@IAMSamuelRodda](https://github.com/IAMSamuelRodda) **Created:** 12/28/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/saved-filters-duplicate` --- ### 📝 Commits (1) - [`71af44a`](https://github.com/go-vikunja/vikunja/commit/71af44a63180c34b8e45ca985e90338c8d2cff23) fix(frontend): prevent saved filters from appearing twice in sidebar ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/stores/projects.ts` (+1 -1) </details> ### 📄 Description ## Summary - Saved filters were appearing in both the Favorites section and the Filters section when marked as favorite - This occurred because `favoriteProjects` included all items with `isFavorite: true`, regardless of whether they were actual projects or saved filters (which have negative IDs) - Added a check for positive IDs (`p.id > 0`) to exclude saved filters from the favorites list ## Test plan - [x] Mark a saved filter as favorite - [x] Verify the filter appears only once in the sidebar (in the Filters section) - [x] Verify regular projects still appear correctly in Favorites when marked as favorite Fixes #1989 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:58:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#8006
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?