github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 21:08:04 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2012] [MERGED] fix(filter): correct filter autocomplete for project names with spaces #7992

New Issue
Closed
opened 2026-04-20 17:58:19 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:58:19 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2012
Author: @kolaente
Created: 12/20/2025
Status: ✅ Merged
Merged: 1/10/2026
Merged by: @kolaente

Base: main ← Head: fix-filter-space-project

📝 Commits (10+)

  • 3900807 fix(frontend): correct filter autocomplete for project names with spaces
  • 8ffedc4 test(frontend): add e2e tests for filter autocomplete with spaces
  • 386c279 refactor(frontend): extract calculateReplacementRange for testability
  • d0cecb1 refactor(tests): use CSS selectors instead of text filtering for buttons
  • 5be6297 test: add e2e tests for filter autocomplete (Issue #2010)
  • d8423a0 fix stuff
  • 203e6dd test: add e2e regression test for filter edit with trailing space (Issue #2010)
  • 153a68a fix(filter): handle closing quotes in autocomplete replacement
  • a6c9091 test(e2e): replace hard-coded timeouts with explicit waits
  • cba4a5a fix(filters): use position-based replacement for label/project IDs

📊 Changes

5 files changed (+638 additions, -72 deletions)

View changed files

➕ frontend/src/components/input/filter/FilterAutocomplete.test.ts (+221 -0)
📝 frontend/src/components/input/filter/FilterAutocomplete.ts (+79 -43)
📝 frontend/src/helpers/filters.test.ts (+23 -1)
📝 frontend/src/helpers/filters.ts (+49 -28)
➕ frontend/tests/e2e/filters/filter-autocomplete.spec.ts (+266 -0)

📄 Description

Filter expressions with multi-word values (such as project names with spaces) are now automatically quoted to preserve them correctly as single tokens in the filter syntax.

Fixes #2010

🐰 A filter's journey, refined with care,
Multi-word values now wear quotes fair,
Offsets aligned by the rabbit's precision,
Autocomplete flows with mathematical vision,
From comma to space, each boundary divine! ✨

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2012 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/20/2025 **Status:** ✅ Merged **Merged:** 1/10/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-filter-space-project` --- ### 📝 Commits (10+) - [`3900807`](https://github.com/go-vikunja/vikunja/commit/39008073b95229b5e8a2de0d65ba989e7f48f31d) fix(frontend): correct filter autocomplete for project names with spaces - [`8ffedc4`](https://github.com/go-vikunja/vikunja/commit/8ffedc46ff946b1dcca18db2771a2eba112ad1a3) test(frontend): add e2e tests for filter autocomplete with spaces - [`386c279`](https://github.com/go-vikunja/vikunja/commit/386c279216063b1caf4903053b11546d8002d727) refactor(frontend): extract calculateReplacementRange for testability - [`d0cecb1`](https://github.com/go-vikunja/vikunja/commit/d0cecb1f5371b85e698750c426f51cb153b0fac0) refactor(tests): use CSS selectors instead of text filtering for buttons - [`5be6297`](https://github.com/go-vikunja/vikunja/commit/5be6297e8e53c2fdc691d2bc071a6a2f0feb6e08) test: add e2e tests for filter autocomplete (Issue #2010) - [`d8423a0`](https://github.com/go-vikunja/vikunja/commit/d8423a00d4723a0458d03a78ca90c99b153cc9f0) fix stuff - [`203e6dd`](https://github.com/go-vikunja/vikunja/commit/203e6dddaf8446079daed2d149fe365c206fea56) test: add e2e regression test for filter edit with trailing space (Issue #2010) - [`153a68a`](https://github.com/go-vikunja/vikunja/commit/153a68a537db29a85c996db287ae9fcae85efbff) fix(filter): handle closing quotes in autocomplete replacement - [`a6c9091`](https://github.com/go-vikunja/vikunja/commit/a6c909168e607fe9e41c2dc0522497e36ff74fb7) test(e2e): replace hard-coded timeouts with explicit waits - [`cba4a5a`](https://github.com/go-vikunja/vikunja/commit/cba4a5ae594d95cff1b5a219fe99d59cad6a04e4) fix(filters): use position-based replacement for label/project IDs ### 📊 Changes **5 files changed** (+638 additions, -72 deletions) <details> <summary>View changed files</summary> ➕ `frontend/src/components/input/filter/FilterAutocomplete.test.ts` (+221 -0) 📝 `frontend/src/components/input/filter/FilterAutocomplete.ts` (+79 -43) 📝 `frontend/src/helpers/filters.test.ts` (+23 -1) 📝 `frontend/src/helpers/filters.ts` (+49 -28) ➕ `frontend/tests/e2e/filters/filter-autocomplete.spec.ts` (+266 -0) </details> ### 📄 Description Filter expressions with multi-word values (such as project names with spaces) are now automatically quoted to preserve them correctly as single tokens in the filter syntax. Fixes #2010 🐰 A filter's journey, refined with care, Multi-word values now wear quotes fair, Offsets aligned by the rabbit's precision, Autocomplete flows with mathematical vision, From comma to space, each boundary divine! ✨ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:58:19 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#7992
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?