github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-16 06:42:23 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1973] [MERGED] fix(tests): unskip and fix Playwright E2E tests #7961

New Issue
Closed
opened 2026-04-20 17:57:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:57:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1973
Author: @kolaente
Created: 12/12/2025
Status: ✅ Merged
Merged: 12/12/2025
Merged by: @kolaente

Base: main ← Head: fix-playwright-tests

📝 Commits (3)

  • cc4f131 fix(tests): unskip and fix Playwright E2E tests
  • 0fa84e6 feat(build): only include data-cy attributes in dev/E2E testing
  • 482fea2 fix: user avatar test

📊 Changes

7 files changed (+70 additions, -30 deletions)

View changed files

📝 .github/workflows/test.yml (+6 -0)
📝 frontend/src/directives/cypress.ts (+14 -3)
📝 frontend/src/views/user/settings/Avatar.vue (+3 -1)
📝 frontend/tests/e2e/task/overview.spec.ts (+4 -4)
📝 frontend/tests/e2e/task/task.spec.ts (+31 -13)
📝 frontend/tests/e2e/user/login.spec.ts (+7 -5)
📝 frontend/tests/e2e/user/settings.spec.ts (+5 -4)

📄 Description

Summary

  • Re-enable 16 previously skipped Playwright E2E tests that now pass
  • Fix test setup issues that were causing flakiness

Changes

  • task/task.spec.ts (8 tests): kanban navigation, description editing, assignees, labels, due dates
  • task/overview.spec.ts (4 tests): task ordering, due date handling
  • user/settings.spec.ts (2 tests): avatar upload, name update
  • user/login.spec.ts (2 tests): bad password error, redirect after login

Key fixes

  • Kanban view tests now properly create TaskBucket entries so tasks appear in the kanban board
  • Avatar upload test uses the API directly to avoid canvas.toBlob() issues in headless browser environments
  • Login redirect test no longer uses the shared login() helper that expected redirect to /

Test plan

  • All 16 previously skipped tests pass locally
  • Full test suite passes (171 tests pass, 3 pre-existing failures unrelated to this PR)
  • CI passes

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1973 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 12/12/2025 **Status:** ✅ Merged **Merged:** 12/12/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-playwright-tests` --- ### 📝 Commits (3) - [`cc4f131`](https://github.com/go-vikunja/vikunja/commit/cc4f131a697018135546906d4631ded19b086eb6) fix(tests): unskip and fix Playwright E2E tests - [`0fa84e6`](https://github.com/go-vikunja/vikunja/commit/0fa84e6101fcdcc30dd541a4599da0105484a0ef) feat(build): only include data-cy attributes in dev/E2E testing - [`482fea2`](https://github.com/go-vikunja/vikunja/commit/482fea2a7d2abec440054df835475ea1ea4afd2b) fix: user avatar test ### 📊 Changes **7 files changed** (+70 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+6 -0) 📝 `frontend/src/directives/cypress.ts` (+14 -3) 📝 `frontend/src/views/user/settings/Avatar.vue` (+3 -1) 📝 `frontend/tests/e2e/task/overview.spec.ts` (+4 -4) 📝 `frontend/tests/e2e/task/task.spec.ts` (+31 -13) 📝 `frontend/tests/e2e/user/login.spec.ts` (+7 -5) 📝 `frontend/tests/e2e/user/settings.spec.ts` (+5 -4) </details> ### 📄 Description ## Summary - Re-enable 16 previously skipped Playwright E2E tests that now pass - Fix test setup issues that were causing flakiness ## Changes - **task/task.spec.ts** (8 tests): kanban navigation, description editing, assignees, labels, due dates - **task/overview.spec.ts** (4 tests): task ordering, due date handling - **user/settings.spec.ts** (2 tests): avatar upload, name update - **user/login.spec.ts** (2 tests): bad password error, redirect after login ## Key fixes - Kanban view tests now properly create `TaskBucket` entries so tasks appear in the kanban board - Avatar upload test uses the API directly to avoid `canvas.toBlob()` issues in headless browser environments - Login redirect test no longer uses the shared `login()` helper that expected redirect to `/` ## Test plan - [x] All 16 previously skipped tests pass locally - [x] Full test suite passes (171 tests pass, 3 pre-existing failures unrelated to this PR) - [ ] CI passes 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:57:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#7961
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?