github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-08-01 18:54:36 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1837] [MERGED] Use Cmd+K for quick actions on macOS instead of Ctrl+K #7851

New Issue
Closed
opened 2026-04-20 17:54:35 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:54:35 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1837
Author: @Copilot
Created: 11/17/2025
Status: ✅ Merged
Merged: 11/17/2025
Merged by: @kolaente

Base: main ← Head: copilot/update-quick-actions-shortcut

📝 Commits (2)

  • 1d2b631 Initial plan
  • 5309b29 feat: make quick actions shortcut platform-specific (Cmd+K on macOS, Ctrl+K elsewhere)

📊 Changes

1 file changed (+6 additions, -1 deletions)

View changed files

📝 frontend/src/components/misc/OpenQuickActions.vue (+6 -1)

📄 Description

The quick actions menu accepted both Ctrl+K and Cmd+K on all platforms. On macOS, this violates platform conventions where Cmd is the primary modifier key.

Changes

Modified OpenQuickActions.vue to enforce platform-specific shortcuts:

  • macOS/iOS: Only Meta+k (Cmd+K)
  • Windows/Linux: Only Control+k (Ctrl+K)
// Before: accepted both on all platforms
if (hotkeyString !== 'Control+k' && hotkeyString !== 'Meta+k') return

// After: platform-specific
const expectedHotkey = isAppleDevice() ? 'Meta+k' : 'Control+k'
if (hotkeyString !== expectedHotkey) return

The keyboard shortcuts UI already displays the correct symbol (⌘ vs Ctrl) per platform.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: node index.js --exec install (dns block)
  • googlechromelabs.github.io
    • Triggering command: node install.mjs (dns block)
  • https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-headless-shell-linux64.zip
    • Triggering command: node install.mjs (http block)
  • https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-linux64.zip
    • Triggering command: node install.mjs (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Pressing ctrl k to open the quick actions menu should be cmd k on macos

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1837 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 11/17/2025 **Status:** ✅ Merged **Merged:** 11/17/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `copilot/update-quick-actions-shortcut` --- ### 📝 Commits (2) - [`1d2b631`](https://github.com/go-vikunja/vikunja/commit/1d2b631a1fa8780d840532ff70c32dae8b75afeb) Initial plan - [`5309b29`](https://github.com/go-vikunja/vikunja/commit/5309b29b235efdaf503a8ddc14c73f1aae284f5e) feat: make quick actions shortcut platform-specific (Cmd+K on macOS, Ctrl+K elsewhere) ### 📊 Changes **1 file changed** (+6 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/misc/OpenQuickActions.vue` (+6 -1) </details> ### 📄 Description The quick actions menu accepted both Ctrl+K and Cmd+K on all platforms. On macOS, this violates platform conventions where Cmd is the primary modifier key. ### Changes Modified `OpenQuickActions.vue` to enforce platform-specific shortcuts: - macOS/iOS: Only `Meta+k` (Cmd+K) - Windows/Linux: Only `Control+k` (Ctrl+K) ```typescript // Before: accepted both on all platforms if (hotkeyString !== 'Control+k' && hotkeyString !== 'Meta+k') return // After: platform-specific const expectedHotkey = isAppleDevice() ? 'Meta+k' : 'Control+k' if (hotkeyString !== expectedHotkey) return ``` The keyboard shortcuts UI already displays the correct symbol (⌘ vs Ctrl) per platform. > [!WARNING] > > <details> > <summary>Firewall rules blocked me from connecting to one or more addresses (expand for details)</summary> > > #### I tried to connect to the following addresses, but was blocked by firewall rules: > > - `download.cypress.io` > - Triggering command: `node index.js --exec install` (dns block) > - `googlechromelabs.github.io` > - Triggering command: `node install.mjs` (dns block) > - `https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-headless-shell-linux64.zip` > - Triggering command: `node install.mjs` (http block) > - `https://storage.googleapis.com/chrome-for-testing-public/131.0.6778.204/linux64/chrome-linux64.zip` > - Triggering command: `node install.mjs` (http block) > > If you need me to access, download, or install something from one of these locations, you can either: > > - Configure [Actions setup steps](https://gh.io/copilot/actions-setup-steps) to set up my environment, which run before the firewall is enabled > - Add the appropriate URLs or hosts to the custom allowlist in this repository's [Copilot coding agent settings](https://github.com/go-vikunja/vikunja/settings/copilot/coding_agent) (admins only) > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > Pressing ctrl k to open the quick actions menu should be cmd k on macos </details> <!-- START COPILOT CODING AGENT TIPS --> --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:54:35 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#7851