github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1398] feat: add independent tasks due today reminders #7518

New Issue
Open
opened 2026-04-20 17:44:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:44:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1398
Author: @kolaente
Created: 9/3/2025
Status: 🔄 Open

Base: main ← Head: codex/analyze-codebase-for-email-task-feature

📝 Commits (10+)

  • 0e621dc fix: address review feedback for today reminders
  • c5ddec0 refactor: rename overdue reminders time field
  • 3109fa4 fix: add missing reminder translations
  • 0ccaf5b fix tests
  • 7c69302 fix: resolve auto-merge issues from rebase
  • 503ca60 fix(plugins): update yaegi symbols for renamed reminder notification
  • 1ff0b18 fix(tests): update web test assertions for renamed task #47 fixture
  • 27c5876 chore: remove PLAN.md from version control
  • cd5c1ba chore: remove generated config.yml.sample from version control
  • e1728ee fix: use double-quoted string for newline in todayLine

📊 Changes

28 files changed (+387 additions, -258 deletions)

View changed files

📝 config-raw.json (+7 -2)
📝 frontend/src/i18n/lang/en.json (+2 -1)
📝 frontend/src/modelTypes/IUserSettings.ts (+2 -1)
📝 frontend/src/models/userSettings.ts (+2 -1)
📝 frontend/src/views/user/settings/General.vue (+24 -16)
📝 frontend/tests/e2e/task/overview.spec.ts (+1 -1)
📝 pkg/config/config.go (+3 -2)
📝 pkg/db/fixtures/task_reminders.yml (+0 -11)
📝 pkg/db/fixtures/tasks.yml (+4 -1)
📝 pkg/db/fixtures/users.yml (+1 -0)
📝 pkg/i18n/lang/en.json (+4 -1)
➕ pkg/migration/20250903072808.go (+40 -0)
➕ pkg/migration/20250903072809.go (+45 -0)
📝 pkg/models/label_task_test.go (+1 -1)
📝 pkg/models/label_test.go (+6 -4)
📝 pkg/models/notifications.go (+48 -59)
📝 pkg/models/project_users_test.go (+3 -2)
📝 pkg/models/task_collection_test.go (+21 -43)
📝 pkg/models/task_reminder.go (+2 -2)
📝 pkg/models/task_today_reminder.go (+84 -59)

...and 8 more files

📄 Description

Summary

  • rename overdue reminder implementation to task_today_reminder and keep userWithTasks structure for overdue and due-today tasks
  • add test fixture task #47 after task #46 and remove redundant config default
  • drop unused Cypress test for today reminders

Testing

  • mage lint:fix (fails: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0))
  • mage test:feature (fails: go: no such tool "covdata" )
  • pnpm lint:fix
  • pnpm lint:styles:fix

https://chatgpt.com/codex/tasks/task_e_68b75b6d6c508322b23c24e9f3e6e26d

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1398 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 9/3/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `codex/analyze-codebase-for-email-task-feature` --- ### 📝 Commits (10+) - [`0e621dc`](https://github.com/go-vikunja/vikunja/commit/0e621dc38a7cd772a2240ae660bf2bbde47d1af0) fix: address review feedback for today reminders - [`c5ddec0`](https://github.com/go-vikunja/vikunja/commit/c5ddec02543f49dc7711975812fb9ef6bf9226dc) refactor: rename overdue reminders time field - [`3109fa4`](https://github.com/go-vikunja/vikunja/commit/3109fa4a7290bd1077f5bf72ec61a3eddef7dd70) fix: add missing reminder translations - [`0ccaf5b`](https://github.com/go-vikunja/vikunja/commit/0ccaf5b47657917cfcc5a5614641a7d5415a501b) fix tests - [`7c69302`](https://github.com/go-vikunja/vikunja/commit/7c69302119afa5b760ad62f9e36b2075a28c7ac8) fix: resolve auto-merge issues from rebase - [`503ca60`](https://github.com/go-vikunja/vikunja/commit/503ca607d199b531147fc8615dcd8cbf47b33e14) fix(plugins): update yaegi symbols for renamed reminder notification - [`1ff0b18`](https://github.com/go-vikunja/vikunja/commit/1ff0b180807fd07a08a45fd3ef9fa0ec72fdfecc) fix(tests): update web test assertions for renamed task #47 fixture - [`27c5876`](https://github.com/go-vikunja/vikunja/commit/27c5876c602b0c07a722f9928598818741d1d590) chore: remove PLAN.md from version control - [`cd5c1ba`](https://github.com/go-vikunja/vikunja/commit/cd5c1ba3e5a1650c4d506f596984560d982bb863) chore: remove generated config.yml.sample from version control - [`e1728ee`](https://github.com/go-vikunja/vikunja/commit/e1728ee0bc054fac1783a0ff309ed561b64158d9) fix: use double-quoted string for newline in todayLine ### 📊 Changes **28 files changed** (+387 additions, -258 deletions) <details> <summary>View changed files</summary> 📝 `config-raw.json` (+7 -2) 📝 `frontend/src/i18n/lang/en.json` (+2 -1) 📝 `frontend/src/modelTypes/IUserSettings.ts` (+2 -1) 📝 `frontend/src/models/userSettings.ts` (+2 -1) 📝 `frontend/src/views/user/settings/General.vue` (+24 -16) 📝 `frontend/tests/e2e/task/overview.spec.ts` (+1 -1) 📝 `pkg/config/config.go` (+3 -2) 📝 `pkg/db/fixtures/task_reminders.yml` (+0 -11) 📝 `pkg/db/fixtures/tasks.yml` (+4 -1) 📝 `pkg/db/fixtures/users.yml` (+1 -0) 📝 `pkg/i18n/lang/en.json` (+4 -1) ➕ `pkg/migration/20250903072808.go` (+40 -0) ➕ `pkg/migration/20250903072809.go` (+45 -0) 📝 `pkg/models/label_task_test.go` (+1 -1) 📝 `pkg/models/label_test.go` (+6 -4) 📝 `pkg/models/notifications.go` (+48 -59) 📝 `pkg/models/project_users_test.go` (+3 -2) 📝 `pkg/models/task_collection_test.go` (+21 -43) 📝 `pkg/models/task_reminder.go` (+2 -2) 📝 `pkg/models/task_today_reminder.go` (+84 -59) _...and 8 more files_ </details> ### 📄 Description ## Summary - rename overdue reminder implementation to task_today_reminder and keep userWithTasks structure for overdue and due-today tasks - add test fixture task #47 after task #46 and remove redundant config default - drop unused Cypress test for today reminders ## Testing - `mage lint:fix` *(fails: can't load config: the Go language version (go1.24) used to build golangci-lint is lower than the targeted Go version (1.25.0))* - `mage test:feature` *(fails: go: no such tool "covdata" )* - `pnpm lint:fix` - `pnpm lint:styles:fix` ------ https://chatgpt.com/codex/tasks/task_e_68b75b6d6c508322b23c24e9f3e6e26d --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:44:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#7518
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?