github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 10:41:50 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #1183] [MERGED] fix: subscription should only be visible for the user who subscribed #7356

New Issue
Closed
opened 2026-04-20 17:39:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 17:39:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/1183
Author: @kolaente
Created: 7/27/2025
Status: ✅ Merged
Merged: 7/28/2025
Merged by: @kolaente

Base: main ← Head: codex/analyze-issue-1181-for-potential-bug

📝 Commits (2)

  • b996ba0 fix: respect user when resolving project subscriptions
  • c5414dd cleanup

📊 Changes

2 files changed (+23 additions, -1 deletions)

View changed files

📝 pkg/models/subscription.go (+1 -1)
📝 pkg/models/subscription_test.go (+22 -0)

📄 Description

Resolve https://github.com/go-vikunja/vikunja/issues/1181

Summary

  • add ANALYSIS.md with reproduction steps and root cause of project subscription issue
  • ensure project subscriptions are filtered by user when resolving task subscriptions
  • add regression test to prevent cross-user project subscriptions from leaking to tasks

Testing

  • mage lint:fix
  • cd frontend && pnpm lint:fix
  • mage test:feature

https://chatgpt.com/codex/tasks/task_e_6886016473e88322b953f02ccc5d4828

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/1183 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 7/27/2025 **Status:** ✅ Merged **Merged:** 7/28/2025 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `codex/analyze-issue-1181-for-potential-bug` --- ### 📝 Commits (2) - [`b996ba0`](https://github.com/go-vikunja/vikunja/commit/b996ba0cce0e3c90295fd20525ac84ed73e67274) fix: respect user when resolving project subscriptions - [`c5414dd`](https://github.com/go-vikunja/vikunja/commit/c5414dd09b5d12f43566b3f0f3d0c3ce7791199f) cleanup ### 📊 Changes **2 files changed** (+23 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/subscription.go` (+1 -1) 📝 `pkg/models/subscription_test.go` (+22 -0) </details> ### 📄 Description Resolve https://github.com/go-vikunja/vikunja/issues/1181 ## Summary - add ANALYSIS.md with reproduction steps and root cause of project subscription issue - ensure project subscriptions are filtered by user when resolving task subscriptions - add regression test to prevent cross-user project subscriptions from leaking to tasks ## Testing - `mage lint:fix` - `cd frontend && pnpm lint:fix` - `mage test:feature` ------ https://chatgpt.com/codex/tasks/task_e_6886016473e88322b953f02ccc5d4828 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-20 17:39:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#7356
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?