github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-11 17:48:44 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #424] [CLOSED] Add comma in greetings #733

New Issue
Closed
opened 2025-11-01 21:03:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:03:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/424
Author: @Senk02
Created: 3/16/2025
Status: ❌ Closed

Base: main ← Head: add-commas

📝 Commits (1)

📊 Changes

10 files changed (+40 additions, -40 deletions)

View changed files

📝 frontend/src/i18n/lang/ca-ES.json (+4 -4)
📝 frontend/src/i18n/lang/en.json (+4 -4)
📝 frontend/src/i18n/lang/eo-UY.json (+4 -4)
📝 frontend/src/i18n/lang/nl-NL.json (+4 -4)
📝 frontend/src/i18n/lang/ro-RO.json (+4 -4)
📝 frontend/src/i18n/lang/sk-SK.json (+4 -4)
📝 frontend/src/i18n/lang/sr-CS.json (+4 -4)
📝 frontend/src/i18n/lang/tr-TR.json (+4 -4)
📝 frontend/src/i18n/lang/vi-VN.json (+4 -4)
📝 frontend/src/i18n/lang/zh-TW.json (+4 -4)

📄 Description

Hey Ladies, Gentlemen, Neither or Both!

I bring a simple grammatical fix here, just added some commas in the greetings.

I think I would recommend also not having "Good night", as that is more of a farewell, and would be better replaced with "Good evening". Let me know if that is something that would be accepted, and I can make a PR for that as well.

That's all for now,

Cheers!

  • Senk0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/424 **Author:** [@Senk02](https://github.com/Senk02) **Created:** 3/16/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `add-commas` --- ### 📝 Commits (1) - [`d49d5d5`](https://github.com/go-vikunja/vikunja/commit/d49d5d5eb66785715751c92185442aa0b3ec5d76) Add comma in greetings ### 📊 Changes **10 files changed** (+40 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/i18n/lang/ca-ES.json` (+4 -4) 📝 `frontend/src/i18n/lang/en.json` (+4 -4) 📝 `frontend/src/i18n/lang/eo-UY.json` (+4 -4) 📝 `frontend/src/i18n/lang/nl-NL.json` (+4 -4) 📝 `frontend/src/i18n/lang/ro-RO.json` (+4 -4) 📝 `frontend/src/i18n/lang/sk-SK.json` (+4 -4) 📝 `frontend/src/i18n/lang/sr-CS.json` (+4 -4) 📝 `frontend/src/i18n/lang/tr-TR.json` (+4 -4) 📝 `frontend/src/i18n/lang/vi-VN.json` (+4 -4) 📝 `frontend/src/i18n/lang/zh-TW.json` (+4 -4) </details> ### 📄 Description Hey Ladies, Gentlemen, Neither or Both! I bring a simple grammatical fix here, just added some commas in the greetings. I think I would recommend also not having "Good night", as that is more of a farewell, and would be better replaced with "Good evening". Let me know if that is something that would be accepted, and I can make a PR for that as well. That's all for now, Cheers! - Senk0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:03:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?