github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-21 17:37:54 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

Bug: Filtering Lists #72

New Issue
Closed
opened 2025-11-01 20:46:08 -05:00 by GiteaMirror · 11 comments
GiteaMirror commented 2025-11-01 20:46:08 -05:00
Owner
Copy Link
Copy Source

Originally created by @mtettke123 on GitHub (Aug 4, 2022).

Using the "filter" button in list view, I can filter "assignees" (small bug: When selecting a person, you can see the selected person a couple of millisecons, then the field is empty again, but the filter works).

Using the "new saved filter" setting in namespaces/lists, filtering with an assignee always returns an empty list.

Small workflow improvement: it would be great if filters in list view could be saved ("save this filter").

Originally created by @mtettke123 on GitHub (Aug 4, 2022). Using the "filter" button in list view, I can filter "assignees" (small bug: When selecting a person, you can see the selected person a couple of millisecons, then the field is empty again, but the filter works). Using the "new saved filter" setting in namespaces/lists, filtering with an assignee always returns an empty list. Small workflow improvement: it would be great if filters in list view could be saved ("save this filter").
GiteaMirror added the bug label 2025-11-01 20:46:08 -05:00
GiteaMirror commented 2025-11-01 20:46:08 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Aug 4, 2022):

Can you reproduce this on try?

@kolaente commented on GitHub (Aug 4, 2022): Can you reproduce this on [try](https://try.vikunja,.io)?
GiteaMirror commented 2025-11-01 20:46:09 -05:00
Author
Owner
Copy Link
Copy Source

@mtettke123 commented on GitHub (Aug 4, 2022):

Well, surprinsingly no. Filtering works here (but I'm using unstable, shouldn't this be the same?). The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to:
grafik

@mtettke123 commented on GitHub (Aug 4, 2022): Well, surprinsingly no. Filtering works here (but I'm using unstable, shouldn't this be the same?). The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to: ![grafik](https://user-images.githubusercontent.com/82048170/182862514-848d892a-00d5-46a6-895d-fc059c702ec8.png)
GiteaMirror commented 2025-11-01 20:46:09 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Aug 4, 2022):

Well, surprinsingly no. Filtering works here

Then it's probably already fixed in unstable.

but I'm using unstable, shouldn't this be the same?

It should, when did you last upgrade?

The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to:

That sounds like another bug. I'll take a look.

@kolaente commented on GitHub (Aug 4, 2022): > Well, surprinsingly no. Filtering works here Then it's probably already fixed in unstable. > but I'm using unstable, shouldn't this be the same? It should, when did you last upgrade? > The small bug (selecting a person that disappears is strange in try, too: Selecting "demo" as user yields to: That sounds like another bug. I'll take a look.
GiteaMirror commented 2025-11-01 20:46:09 -05:00
Author
Owner
Copy Link
Copy Source

@mtettke123 commented on GitHub (Aug 5, 2022):

Filtering seems to be solved. Just updated. works.

The small bug is still there (in my installation: selected person disappers like if no one is selected, but filter works)...

@mtettke123 commented on GitHub (Aug 5, 2022): Filtering seems to be solved. Just updated. works. The small bug is still there (in my installation: selected person disappers like if no one is selected, but filter works)...
GiteaMirror commented 2025-11-01 20:46:09 -05:00
Author
Owner
Copy Link
Copy Source

@glungtung commented on GitHub (Aug 13, 2022):

I confirm
Person disappears immediatly after selection in Assignees
But filter can be created and is working

@glungtung commented on GitHub (Aug 13, 2022): I confirm Person disappears immediatly after selection in Assignees But filter can be created and is working
GiteaMirror commented 2025-11-01 20:46:09 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Aug 15, 2022):

The cause of this problem is a little complicated and has two parts.

In the frontend, the bug occurs because the filter value changes after a user was selected. This triggers a rebuild of all filter values which for the assignee filter means a search request to get the full name etc of the user. BUT the assignee filter only stores user ids and the user search endpoint does not handle those (to prevent usernames leaking by just increasing the id). Therefore, the search returns no results and the user disappears. The filter component does this to show the correct values if the filter changed from the outside (aka was just loaded).
This can be fixed with a check if there's already data loaded and not loading it if that's the case. Still not ideal because then it won't update if the filter is changed from the outside again after loading it but we're not doing that at the moment.

The other problem is the mentioned filter search: Because we can't lookup user IDs we should ideally save usernames. They are unique and relatively un-guessable (no enumeration possible). If we save usernames instead of IDs we'll need to change the filter logic so that it is able to search by username instead of ID. Possible. but a breaking change.

@kolaente commented on GitHub (Aug 15, 2022): The cause of this problem is a little complicated and has two parts. In the frontend, the bug occurs because the filter value changes after a user was selected. This triggers a rebuild of all filter values which for the assignee filter means a search request to get the full name etc of the user. BUT the assignee filter only stores user ids and the user search endpoint does not handle those (to prevent usernames leaking by just increasing the id). Therefore, the search returns no results and the user disappears. The filter component does this to show the correct values if the filter changed from the outside (aka was just loaded). This can be fixed with a check if there's already data loaded and not loading it if that's the case. Still not ideal because then it won't update if the filter is changed from the outside again after loading it but we're not doing that at the moment. The other problem is the mentioned filter search: Because we can't lookup user IDs we should ideally save usernames. They are unique and relatively un-guessable (no enumeration possible). If we save usernames instead of IDs we'll need to change the filter logic so that it is able to search by username instead of ID. Possible. but a breaking change.
GiteaMirror commented 2025-11-01 20:46:09 -05:00
Author
Owner
Copy Link
Copy Source

@ToniMurcia commented on GitHub (Aug 29, 2022):

Filtering by asignee works great in list view but not in kanban, it always returns an empty list.

@ToniMurcia commented on GitHub (Aug 29, 2022): Filtering by asignee works great in list view but not in kanban, it always returns an empty list.
GiteaMirror commented 2025-11-01 20:46:10 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Sep 1, 2022):

Filtering by asignee works great in list view but not in kanban, it always returns an empty list.

Filters are not supported for kanban right now.

@kolaente commented on GitHub (Sep 1, 2022): > Filtering by asignee works great in list view but not in kanban, it always returns an empty list. Filters are not supported for kanban right now.
GiteaMirror commented 2025-11-01 20:46:10 -05:00
Author
Owner
Copy Link
Copy Source

@ToniMurcia commented on GitHub (Sep 2, 2022):

Do you mean "Filters are not supported for kanban" only for assignee field? Because the rest of fields work great when filtering in kanban view: labels, priority, progress, etc.

@ToniMurcia commented on GitHub (Sep 2, 2022): Do you mean "Filters are not supported for kanban" only for assignee field? Because the rest of fields work great when filtering in kanban view: labels, priority, progress, etc.
GiteaMirror commented 2025-11-01 20:46:10 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Sep 2, 2022):

I mean you can't filter by Kanban buckets or view a saved filter in Kanban view.

@kolaente commented on GitHub (Sep 2, 2022): I mean you can't filter by Kanban buckets or view a saved filter in Kanban view.
GiteaMirror commented 2025-11-01 20:46:10 -05:00
Author
Owner
Copy Link
Copy Source

@kolaente commented on GitHub (Mar 14, 2023):

This has been fixed in the meantime.

@kolaente commented on GitHub (Mar 14, 2023): This has been fixed in the meantime.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No labels bug
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#72