github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-03-08 23:03:29 -05:00
Code Issues 219 Packages Projects Releases 2 Wiki Activity

[PR #351] [CLOSED] tasks: also delete corresponding task positions #718

New Issue
Closed
opened 2025-11-01 21:02:46 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-01 21:02:46 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/351
Author: @Ma27
Created: 11/10/2024
Status: ❌ Closed

Base: main ← Head: fix-filter-bucket-on-move

📝 Commits (1)

  • 14bfe61 tasks: also delete corresponding task positions

📊 Changes

1 file changed (+5 additions, -1 deletions)

View changed files

📝 pkg/models/tasks.go (+5 -1)

📄 Description

Closes #348

When moving a project, the old task bucket entries (project, saved filters) will be removed, but not the corresponding position. This has the effect that the saved_filter event hook UpdateTaskInSavedFilterViews wrongly assumes that the task doesn't need to be re-added to the saved filter since the position part still exists.

cc @kolaente

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/351 **Author:** [@Ma27](https://github.com/Ma27) **Created:** 11/10/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-filter-bucket-on-move` --- ### 📝 Commits (1) - [`14bfe61`](https://github.com/go-vikunja/vikunja/commit/14bfe618ab0067511593f44284659284f1f04336) tasks: also delete corresponding task positions ### 📊 Changes **1 file changed** (+5 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/tasks.go` (+5 -1) </details> ### 📄 Description Closes #348 When moving a project, the old task bucket entries (project, saved filters) will be removed, but not the corresponding position. This has the effect that the saved_filter event hook UpdateTaskInSavedFilterViews wrongly assumes that the task doesn't need to be re-added to the saved filter since the position part still exists. cc @kolaente --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-01 21:02:46 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/caldav
area/filters
area/frontend
area/gantt
area/internal-code
area/typesense
bug
changes requested
confirmed
dependencies
enhancement
good first issue
help wanted
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?