github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 12:57:52 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[GH-ISSUE #2347] Evaluate replacing afero-s3 with direct S3 SDK usage #6647

New Issue
Closed
opened 2026-04-20 17:14:27 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-20 17:14:27 -05:00
Owner
Copy Link

Originally created by @tink-bot on GitHub (Mar 3, 2026).
Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/2347

Context

In #2313 we merged a temporary fork of afero-s3 to fix a severe S3 read performance regression (every Read() call was opening a new HTTP connection, resulting in ~320 requests for a 10MB file).

As discussed in that PR, we should evaluate whether to keep using afero-s3 at all, or replace it with direct AWS S3 SDK usage. We don't use many S3 APIs, so the abstraction layer may not be worth the maintenance burden and exposure to upstream regressions like this one.

Tasks

  • Audit current afero-s3 usage in the codebase — which afero.Fs methods do we actually use?
  • Evaluate effort to replace with direct aws-sdk-go (or v2) calls
  • Remove the replace directive in go.mod once upstream merges the fix (https://github.com/fclairamb/afero-s3/pull/938), or proceed with full removal

cc @kolaente @maggch97

Originally created by @tink-bot on GitHub (Mar 3, 2026). Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/2347 ## Context In #2313 we merged a temporary fork of afero-s3 to fix a severe S3 read performance regression (every `Read()` call was opening a new HTTP connection, resulting in ~320 requests for a 10MB file). As discussed in that PR, we should evaluate whether to keep using afero-s3 at all, or replace it with direct AWS S3 SDK usage. We don't use many S3 APIs, so the abstraction layer may not be worth the maintenance burden and exposure to upstream regressions like this one. ## Tasks - [ ] Audit current afero-s3 usage in the codebase — which `afero.Fs` methods do we actually use? - [ ] Evaluate effort to replace with direct `aws-sdk-go` (or v2) calls - [ ] Remove the `replace` directive in `go.mod` once upstream merges the fix (https://github.com/fclairamb/afero-s3/pull/938), or proceed with full removal cc @kolaente @maggch97
GiteaMirror commented 2026-04-20 17:14:28 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Mar 3, 2026):

@maggch97 any thoughts?

<!-- gh-comment-id:3990623321 --> @kolaente commented on GitHub (Mar 3, 2026): @maggch97 any thoughts?
GiteaMirror commented 2026-04-20 17:14:28 -05:00
Author
Owner
Copy Link

@vikunja-bot-app[bot] commented on GitHub (Mar 20, 2026):

This issue has been fixed in #2418, please check with the next unstable build (should be ready for deployment in ~30min, also on the demo).

<!-- gh-comment-id:4096954913 --> @vikunja-bot-app[bot] commented on GitHub (Mar 20, 2026): This issue has been fixed in #2418, please check with the next unstable build (should be ready for deployment in ~30min, also on [the demo](https://try.vikunja.io)).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#6647
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?