github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-05 19:18:16 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[GH-ISSUE #2329] bug: new task gets wrong position in views other than the one it was created in #6641

New Issue
Closed
opened 2026-04-20 17:14:09 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-20 17:14:09 -05:00
Owner
Copy Link

Originally created by @maggch97 on GitHub (Mar 2, 2026).
Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/2329

Description

When creating a task in a project that has multiple views (e.g. two list views), the new task gets the correct position (top of the list) only in the view where it was created. In all other views, it appears in the middle of the list with an incorrect position value.

Root Cause

In calculateNewPositionForTask (pkg/models/task_position.go:330), the calculated position is written back to the shared *Task struct:

t.Position = lowestPosition.Position / 2

This function is called in a loop over all views in setTaskInBucketInViews (pkg/models/tasks.go), sharing the same *Task pointer. After the first view sets t.Position, subsequent views see t.Position != 0 and skip the position calculation entirely, reusing the value from the first view.

Steps to Reproduce

  1. Create a project with two list views (View A and View B)
  2. Open View A, which has tasks with positions in a certain range
  3. Create a new task in View A
  4. Switch to View B — the new task appears in the middle instead of at the top

Expected Behavior

The new task should appear at the top of every view, with each view independently calculating the position based on its own lowest position.

Fix

Use a local variable instead of modifying t.Position:

position := lowestPosition.Position / 2
// ...
Position: calculateDefaultPosition(t.Index, position),

Introduced in commit 429c7ca2c (feat(task): always insert new tasks at the top).

Originally created by @maggch97 on GitHub (Mar 2, 2026). Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/2329 ## Description When creating a task in a project that has multiple views (e.g. two list views), the new task gets the correct position (top of the list) only in the view where it was created. In all other views, it appears in the middle of the list with an incorrect position value. ## Root Cause In `calculateNewPositionForTask` (pkg/models/task_position.go:330), the calculated position is written back to the shared `*Task` struct: ```go t.Position = lowestPosition.Position / 2 ``` This function is called in a loop over all views in `setTaskInBucketInViews` (pkg/models/tasks.go), sharing the same `*Task` pointer. After the first view sets `t.Position`, subsequent views see `t.Position != 0` and skip the position calculation entirely, reusing the value from the first view. ## Steps to Reproduce 1. Create a project with two list views (View A and View B) 2. Open View A, which has tasks with positions in a certain range 3. Create a new task in View A 4. Switch to View B — the new task appears in the middle instead of at the top ## Expected Behavior The new task should appear at the top of every view, with each view independently calculating the position based on its own lowest position. ## Fix Use a local variable instead of modifying `t.Position`: ```go position := lowestPosition.Position / 2 // ... Position: calculateDefaultPosition(t.Index, position), ``` Introduced in commit 429c7ca2c (`feat(task): always insert new tasks at the top`).
GiteaMirror commented 2026-04-20 17:14:10 -05:00
Author
Owner
Copy Link

@maggch97 commented on GitHub (Mar 2, 2026):

Fix is included in https://github.com/go-vikunja/vikunja/pull/2320 (commit 3f4bdf2a2).

<!-- gh-comment-id:3981721031 --> @maggch97 commented on GitHub (Mar 2, 2026): Fix is included in https://github.com/go-vikunja/vikunja/pull/2320 (commit 3f4bdf2a2).
GiteaMirror commented 2026-04-20 17:14:11 -05:00
Author
Owner
Copy Link

@vikunja-bot-app[bot] commented on GitHub (Mar 2, 2026):

This issue has been fixed in #2320, please check with the next unstable build (should be ready for deployment in ~30min, also on the demo).

<!-- gh-comment-id:3982830726 --> @vikunja-bot-app[bot] commented on GitHub (Mar 2, 2026): This issue has been fixed in #2320, please check with the next unstable build (should be ready for deployment in ~30min, also on [the demo](https://try.vikunja.io)).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#6641
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?