github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 02:32:22 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[GH-ISSUE #1545] [v1.0.0-rc2] Duplicated SQL condition proposed fix #6439

New Issue
Closed
opened 2026-04-20 17:02:30 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-20 17:02:30 -05:00
Owner
Copy Link

Originally created by @Mattiam2 on GitHub (Sep 25, 2025).
Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/1545

I've noticed debugging the application in the last Vikunja version (v1.0.0-rc2) that when creating a filter with more than two conditions in && or ||, the generated SQL query duplicates the condition in the middle.

For example, if the filter is: A && B && C

The generated SQL condition in "Where" is: A && B && B && C

Editing the code I managed to fix this issue by rewriting the final filter construction in:
8c4fc4780e/pkg/models/task_search.go (L228-L243)

My proposed fix changes that code block to:

if len(dbFilters) > 0 {
	filterCond = dbFilters[0]
	if len(dbFilters) >= 1 {
		for i := range dbFilters {
			if len(dbFilters) > i+1 {
				switch rawFilters[i+1].join {
				case filterConcatOr:
					filterCond = builder.Or(filterCond, dbFilters[i+1])
				case filterConcatAnd:
					filterCond = builder.And(filterCond, dbFilters[i+1])
				}
			}
		}
	}
}
Originally created by @Mattiam2 on GitHub (Sep 25, 2025). Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/1545 I've noticed debugging the application in the last Vikunja version (v1.0.0-rc2) that when creating a filter with more than two conditions in && or ||, the generated SQL query duplicates the condition in the middle. For example, if the filter is: _A && B && C_ The generated SQL condition in "Where" is: _A && **B && B** && C_ Editing the code I managed to fix this issue by rewriting the final filter construction in: https://github.com/go-vikunja/vikunja/blob/8c4fc4780ed1d10d667bb57f3c32ef472844254e/pkg/models/task_search.go#L228-L243 My proposed fix changes that code block to: ``` if len(dbFilters) > 0 { filterCond = dbFilters[0] if len(dbFilters) >= 1 { for i := range dbFilters { if len(dbFilters) > i+1 { switch rawFilters[i+1].join { case filterConcatOr: filterCond = builder.Or(filterCond, dbFilters[i+1]) case filterConcatAnd: filterCond = builder.And(filterCond, dbFilters[i+1]) } } } } } ```
GiteaMirror commented 2026-04-20 17:02:32 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Sep 25, 2025):

Do you want to send a PR?

<!-- gh-comment-id:3332410432 --> @kolaente commented on GitHub (Sep 25, 2025): Do you want to send a PR?
GiteaMirror commented 2026-04-20 17:02:32 -05:00
Author
Owner
Copy Link

@Mattiam2 commented on GitHub (Sep 25, 2025):

Created the pull request

<!-- gh-comment-id:3332462239 --> @Mattiam2 commented on GitHub (Sep 25, 2025): Created the pull request
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#6439
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?