github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[GH-ISSUE #1359] Error Popup at signin #6369

New Issue
Closed
opened 2026-04-20 16:57:42 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-20 16:57:42 -05:00
Owner
Copy Link

Originally created by @xeruf on GitHub (Aug 30, 2025).
Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/1359

Originally assigned to: @Copilot on GitHub.

Description

In both 0.24.6 and on latest:
Error can't access property "backdropView", window.history.state is null

Vikunja Version

latest

Browser and version

No response

Can you reproduce the bug on the Vikunja demo site?

Please select

Screenshots

No response

Originally created by @xeruf on GitHub (Aug 30, 2025). Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/1359 Originally assigned to: @Copilot on GitHub. ### Description In both 0.24.6 and on latest: Error can't access property "backdropView", window.history.state is null ### Vikunja Version latest ### Browser and version _No response_ ### Can you reproduce the bug on the Vikunja demo site? Please select ### Screenshots _No response_
GiteaMirror commented 2026-04-20 16:57:43 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Aug 31, 2025):

Analysis:

Investigation

  • Search for backdropView in frontend code.
  • Found src/composables/useRouteWithModal.ts accesses window.history.state.backdropView without checking if window.history.state exists.
  • If a user navigates directly to a task or reloads the page, window.history.state is null. Attempting to access backdropView on null causes "Error can't access property 'backdropView', window.history.state is null".

Proposed fix

  • Guard the history state access with optional chaining: 
    const backdropView = computed(() => route.fullPath ? window.history.state?.backdropView : undefined)
  • This returns undefined when no history.state is present, preventing the crash.
  • Ensure any code that relies on backdropView handles the undefined case gracefully.

Testing ideas

  • Load a task directly via its URL to confirm the app no longer throws an error.
  • Open a task from a project view (where backdropView exists) to ensure modal navigation still works.
<!-- gh-comment-id:3240314367 --> @kolaente commented on GitHub (Aug 31, 2025): Analysis: ### Investigation - Search for `backdropView` in frontend code. - Found `src/composables/useRouteWithModal.ts` accesses `window.history.state.backdropView` without checking if `window.history.state` exists. - If a user navigates directly to a task or reloads the page, `window.history.state` is `null`. Attempting to access `backdropView` on `null` causes "Error can't access property 'backdropView', window.history.state is null". ### Proposed fix - Guard the history state access with optional chaining: ```ts const backdropView = computed(() => route.fullPath ? window.history.state?.backdropView : undefined) ``` - This returns `undefined` when no `history.state` is present, preventing the crash. - Ensure any code that relies on `backdropView` handles the `undefined` case gracefully. ### Testing ideas - Load a task directly via its URL to confirm the app no longer throws an error. - Open a task from a project view (where `backdropView` exists) to ensure modal navigation still works.
GiteaMirror commented 2026-04-20 16:57:43 -05:00
Author
Owner
Copy Link

@kolaente commented on GitHub (Aug 31, 2025):

Fixed in https://github.com/go-vikunja/vikunja/pull/1368, please check with the next unstable build (should be ready for deployment in ~30min, also on try).

<!-- gh-comment-id:3240353906 --> @kolaente commented on GitHub (Aug 31, 2025): Fixed in https://github.com/go-vikunja/vikunja/pull/1368, please check with the next unstable build (should be ready for deployment in ~30min, also on [try](https://try.vikunja.io)).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#6369
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?