github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-05 19:18:16 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[GH-ISSUE #524] Improvements for Link Sharing Modal #6217

New Issue
Open
opened 2026-04-20 16:48:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-20 16:48:38 -05:00
Owner
Copy Link

Originally created by @vikunja-bot on GitHub (Apr 1, 2025).
Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/524

Original issue by dpschen on 2022-09-14T15:55:23.000Z

Copying over from https://kolaente.dev/vikunja/frontend/pulls/2335#issuecomment-35155

When testing the sharing functionality again I stumbled over a few issues:

  • Unsure: move the 'Create a new link share'-Button and the create-form below the list of already created shares. This way it's clear that the newly created share is added to the bottom of the list. Possible downside: out of view on mobile and small desktop windows.

  • Non reversible UI action: Clicking the 'Create a new link share'-Button should be reversible if you clicked there by mistake. Aka: add a 'Cancel' or 'x' button in the inline form.

  • Inline form the create a new share link is hard to tell apart from the rest of the form.
    image

  • Missing space between 'Cancel' and 'Create' button. This might be a sideeffect from some of my Modal changes, but might make sense to look into this here. Seems like a gap property is missing for .card-footer.
    image

  •  When clicking the copy button it should be indicated that the new link is now in the clipboard. E.g. marking the copy button green and adding checkmark or success message. Would prefer the checkmark since this way the user doesn't loose context and the feedback is immediately and inline. After a few seconds the button should go back in its initial state. This button or maybe the whole input should be abstracted dedicated component

  • This is a general issue on mobile: It's hard to make the tooltip of 'What is a share link?' appear. Tapping makes it appear but it will directly disappear again. Since the info is so short I think we can remove the tooltip here completely and simply show the explaining text.

  • Picky: The tap area of the copy button seems to small on mobile. It would benefit from an aspect-ratio: 1/1;

Original issue on Gitea

xeruf commented on 2022-09-24T23:15:45.000Z:

I guess I'll just tack this on here: Visiting something like /lists/43/settings/share creates an uncloseable popup ^^

@kolaente commented on 2022-09-26T12:23:58.000Z:

@xeruf Is that reproducible on try?

xeruf commented on 2022-09-27T15:04:49.000Z:

well, not uncloseable there, but still unexpected: https://try.vikunja.io/list/1/settings/share
because it just says not found

however, when it points to a list not created by myself, I get this uncloseable popup

@kolaente commented on 2022-09-27T15:06:07.000Z:

That url should be /lists/1/settings/share (notice the additional s for lists).

xeruf commented on 2022-09-28T10:12:51.000Z:

Ah right, I keep making that mistake. Nonetheless, try opening these in a new tab an clicking the x in the popup:
https://try.vikunja.io/lists/1/settings/edit
https://try.vikunja.io/lists/1/settings/share

It tries to navigate back, which is unexpected.
I think vikunja should check whether the previous page is on the same domain, otherwise just show the list on close.

dpschen commented on 2022-09-28T10:30:54.000Z:

I think vikunja should check whether the previous page is on the same domain, otherwise just show the list on close.

I agree with this. I see this problem everywhere where we use router.back().
I'm not sure if checking the domain is the right approach. Maybe we should check if the last history entry contains the app base path instead

xeruf commented on 2022-09-28T10:43:47.000Z:

Exactly that is what I meant :)

Furthermore, my colleague just had an issue with his jwt token being invalidated when he clicked on the link, logged in, and closed the popup - it looked like he was logged in, but all lists appeared empty. Very confusing.

@kolaente commented on 2022-09-28T13:38:06.000Z:

Maybe we should check if the last history entry contains the app base path instead

That sounds like a good approach. I've added an item in the backlog for this.

dpschen commented on 2022-11-22T11:49:57.000Z:

I try to tackle the modal navigation issues with https://kolaente.dev/vikunja/frontend/pulls/2735

Originally created by @vikunja-bot on GitHub (Apr 1, 2025). Original GitHub issue: https://github.com/go-vikunja/vikunja/issues/524 _Original issue by dpschen on 2022-09-14T15:55:23.000Z_ Copying over from https://kolaente.dev/vikunja/frontend/pulls/2335#issuecomment-35155 When testing the sharing functionality again I stumbled over a few issues: - [ ] Unsure: move the 'Create a new link share'-Button and the create-form below the list of already created shares. This way it's clear that the newly created share is added to the bottom of the list. Possible downside: out of view on mobile and small desktop windows. - [ ] Non reversible UI action: Clicking the 'Create a new link share'-Button should be reversible if you clicked there by mistake. Aka: add a 'Cancel' or 'x' button in the inline form. - [ ] Inline form the create a new share link is hard to tell apart from the rest of the form. ![image](/attachments/1b4303a8-e358-4454-a9a3-64813374d640) - [ ] Missing space between 'Cancel' and 'Create' button. This might be a sideeffect from some of my Modal changes, but might make sense to look into this here. Seems like a `gap` property is missing for `.card-footer`. ![image](/attachments/98923d63-ee66-47dc-873d-54aaab054a30) - [ ] When clicking the copy button it should be indicated that the new link is now in the clipboard. E.g. marking the copy button green and adding checkmark or success message. Would prefer the checkmark since this way the user doesn't loose context and the feedback is immediately and inline. After a few seconds the button should go back in its initial state. This button or maybe the whole input should be abstracted dedicated component - [ ] This is a general issue on mobile: It's hard to make the tooltip of 'What is a share link?' appear. Tapping makes it appear but it will directly disappear again. Since the info is so short I think we can remove the tooltip here completely and simply show the explaining text. - [ ] Picky: The tap area of the copy button seems to small on mobile. It would benefit from an `aspect-ratio: 1/1;` [Original issue on Gitea](https://kolaente.dev/vikunja/vikunja/issues/1980) --- _**xeruf** commented on 2022-09-24T23:15:45.000Z_: I guess I'll just tack this on here: Visiting something like `/lists/43/settings/share` creates an uncloseable popup ^^ --- _**@kolaente** commented on 2022-09-26T12:23:58.000Z_: @xeruf Is that reproducible on try? --- _**xeruf** commented on 2022-09-27T15:04:49.000Z_: well, not uncloseable there, but still unexpected: https://try.vikunja.io/list/1/settings/share because it just says not found however, when it points to a list not created by myself, I get this uncloseable popup --- _**@kolaente** commented on 2022-09-27T15:06:07.000Z_: That url should be `/lists/1/settings/share` (notice the additional `s` for `lists`). --- _**xeruf** commented on 2022-09-28T10:12:51.000Z_: Ah right, I keep making that mistake. Nonetheless, try opening these in a new tab an clicking the x in the popup: https://try.vikunja.io/lists/1/settings/edit https://try.vikunja.io/lists/1/settings/share It tries to navigate back, which is unexpected. I think vikunja should check whether the previous page is on the same domain, otherwise just show the list on close. --- _**dpschen** commented on 2022-09-28T10:30:54.000Z_: > I think vikunja should check whether the previous page is on the same domain, otherwise just show the list on close. I agree with this. I see this problem everywhere where we use `router.back()`. I'm not sure if checking the domain is the right approach. Maybe we should check if the last history entry contains the app base path instead --- _**xeruf** commented on 2022-09-28T10:43:47.000Z_: Exactly that is what I meant :) Furthermore, my colleague just had an issue with his jwt token being invalidated when he clicked on the link, logged in, and closed the popup - it looked like he was logged in, but all lists appeared empty. Very confusing. --- _**@kolaente** commented on 2022-09-28T13:38:06.000Z_: > Maybe we should check if the last history entry contains the app base path instead That sounds like a good approach. I've added an item in the backlog for this. --- _**dpschen** commented on 2022-11-22T11:49:57.000Z_: I try to tackle the modal navigation issues with https://kolaente.dev/vikunja/frontend/pulls/2735
GiteaMirror added the changes requestedarea/permissionsconcern/ux labels 2026-04-20 16:48:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label area/permissions changes requested concern/ux
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#6217
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?