github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 12:57:52 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2639] [MERGED] refactor(frontend): drop Bulma components/card import #5789

New Issue
Closed
opened 2026-04-16 13:52:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:52:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2639
Author: @tink-bot
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/16/2026
Merged by: @kolaente

Base: main ← Head: refactor-drop-bulma-card

📝 Commits (3)

  • 84a0762 refactor(frontend): drop Bulma components/card import
  • 5e7db93 fix(frontend): restore bold card header and tighten content padding
  • bf66899 fix(frontend): restore Bulma card-content padding and utility override

📊 Changes

2 files changed (+50 additions, -1 deletions)

View changed files

📝 frontend/src/components/misc/Card.vue (+49 -0)
📝 frontend/src/styles/global.scss (+1 -1)

📄 Description

Summary

  • The Bulma components/card partial defined .card / .card-header / .card-header-title / .card-header-icon / .card-content / .card-footer. These classes are only emitted by Card.vue (a few external components reach in via :deep(.card-content) / :deep(.card) selectors — those keep working because the class names are unchanged).
  • Ported the still-effective Bulma rules into Card.vue's scoped <style> block (using logical properties to match the file's existing convention) and replaced the import in global.scss with a comment.
  • Skipped Bulma rules already shadowed by Card.vue (background-color, border-radius, box-shadow on .card; box-shadow on .card-header; background-color/border-top/display/padding on .card-footer) and skipped .card-image, .card-footer-item, .card .media:not(:last-child) because Card.vue does not emit those classes.

Test plan

  • pnpm test:unit — 969 tests pass
  • pnpm lint:styles — clean
  • Visual: Settings → General (heavy Card usage — Personal Information, Projects & Tasks, Localization, Appearance & Behavior, Privacy cards) renders correctly with proper backgrounds, borders, headers, and padding.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2639 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/16/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `refactor-drop-bulma-card` --- ### 📝 Commits (3) - [`84a0762`](https://github.com/go-vikunja/vikunja/commit/84a0762ee46a25fb60fa94da1dae7f1c1b474dee) refactor(frontend): drop Bulma components/card import - [`5e7db93`](https://github.com/go-vikunja/vikunja/commit/5e7db938dabbf9189775783ea34ae873260bfe62) fix(frontend): restore bold card header and tighten content padding - [`bf66899`](https://github.com/go-vikunja/vikunja/commit/bf66899cc0b1845e5a57fba502db9f976a533fdd) fix(frontend): restore Bulma card-content padding and utility override ### 📊 Changes **2 files changed** (+50 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/misc/Card.vue` (+49 -0) 📝 `frontend/src/styles/global.scss` (+1 -1) </details> ### 📄 Description ## Summary - The Bulma `components/card` partial defined `.card` / `.card-header` / `.card-header-title` / `.card-header-icon` / `.card-content` / `.card-footer`. These classes are only emitted by `Card.vue` (a few external components reach in via `:deep(.card-content)` / `:deep(.card)` selectors — those keep working because the class names are unchanged). - Ported the still-effective Bulma rules into `Card.vue`'s scoped `<style>` block (using logical properties to match the file's existing convention) and replaced the import in `global.scss` with a comment. - Skipped Bulma rules already shadowed by `Card.vue` (background-color, border-radius, box-shadow on `.card`; box-shadow on `.card-header`; background-color/border-top/display/padding on `.card-footer`) and skipped `.card-image`, `.card-footer-item`, `.card .media:not(:last-child)` because `Card.vue` does not emit those classes. ## Test plan - [x] `pnpm test:unit` — 969 tests pass - [x] `pnpm lint:styles` — clean - [x] Visual: Settings → General (heavy Card usage — Personal Information, Projects & Tasks, Localization, Appearance & Behavior, Privacy cards) renders correctly with proper backgrounds, borders, headers, and padding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:52:16 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5789
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?