github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-15 22:32:29 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2637] [MERGED] refactor(frontend): drop Bulma components/media import #5787

New Issue
Closed
opened 2026-04-16 13:52:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:52:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2637
Author: @tink-bot
Created: 4/15/2026
Status: ✅ Merged
Merged: 4/15/2026
Merged by: @kolaente

Base: main ← Head: refactor-drop-bulma-media

📝 Commits (1)

  • 41d10e8 refactor(frontend): drop Bulma components/media import

📊 Changes

2 files changed (+20 additions, -1 deletions)

View changed files

📝 frontend/src/components/tasks/partials/Comments.vue (+19 -0)
📝 frontend/src/styles/global.scss (+1 -1)

📄 Description

Summary

The Bulma components/media partial's classes (.media, .media-left, .media-content) are only used in Comments.vue. This ports the rules actually exercised there into the component's scoped <style> block (using logical properties) and drops the global partial import.

Skipped from the original partial: nested .media .media rules, .is-large size variants, the .media .content:not(:last-child) selector, and .media-right — none are used in this codebase.

Test plan

  • pnpm lint:styles passes
  • pnpm test:unit passes (969/969)
  • Visual verification via dev server was not performed — Comments.vue is hard to exercise meaningfully without real task data, and the change is a like-for-like CSS port. Reviewer / CI should sanity-check comment rendering.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2637 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/15/2026 **Status:** ✅ Merged **Merged:** 4/15/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `refactor-drop-bulma-media` --- ### 📝 Commits (1) - [`41d10e8`](https://github.com/go-vikunja/vikunja/commit/41d10e8edba49fed20866293184115bcec29b959) refactor(frontend): drop Bulma components/media import ### 📊 Changes **2 files changed** (+20 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/tasks/partials/Comments.vue` (+19 -0) 📝 `frontend/src/styles/global.scss` (+1 -1) </details> ### 📄 Description ## Summary The Bulma `components/media` partial's classes (`.media`, `.media-left`, `.media-content`) are only used in `Comments.vue`. This ports the rules actually exercised there into the component's scoped `<style>` block (using logical properties) and drops the global partial import. Skipped from the original partial: nested `.media .media` rules, `.is-large` size variants, the `.media .content:not(:last-child)` selector, and `.media-right` — none are used in this codebase. ## Test plan - `pnpm lint:styles` passes - `pnpm test:unit` passes (969/969) - Visual verification via dev server was **not** performed — Comments.vue is hard to exercise meaningfully without real task data, and the change is a like-for-like CSS port. Reviewer / CI should sanity-check comment rendering. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:52:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5787
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?