github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 12:57:52 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2621] [MERGED] fix(frontend/kanban): honor server bucket redirect when dropping a recurring task on Done #5775

New Issue
Closed
opened 2026-04-16 13:51:52 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:51:52 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2621
Author: @tink-bot
Created: 4/14/2026
Status: ✅ Merged
Merged: 4/14/2026
Merged by: @kolaente

Base: main ← Head: fix-recurring-kanban-ui-update

📝 Commits (4)

  • 7273a0d fix(frontend/kanban): honor server bucket redirect on drag (#2618)
  • accb29b test(kanban): cover moveTaskToBucket
  • 942bdc5 test(e2e/kanban): cover recurring task drag to done bucket (#2618)
  • 830b546 test(e2e/kanban): seed the view only once with done_bucket_id

📊 Changes

3 files changed (+137 additions, -1 deletions)

View changed files

📝 frontend/src/components/project/views/ProjectKanban.vue (+1 -1)
➕ frontend/src/stores/kanban.test.ts (+93 -0)
📝 frontend/tests/e2e/project/project-view-kanban.spec.ts (+43 -0)

📄 Description

When a recurring task is dragged to the Done bucket, the backend correctly resets the task and returns a different bucketId in the response, but the frontend ignored that redirect — the card stayed visually in Done until the page was refreshed.

The guard in ProjectKanban.vue that was meant to detect a server-side bucket change was tautologically false because newTask.bucketId was assigned from the response one line before the comparison. Reordered so the comparison fires on the pre-response bucket.

Fixes #2618

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2621 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/14/2026 **Status:** ✅ Merged **Merged:** 4/14/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-recurring-kanban-ui-update` --- ### 📝 Commits (4) - [`7273a0d`](https://github.com/go-vikunja/vikunja/commit/7273a0d9e45146482d68aa8cf351734e8a9a6c2a) fix(frontend/kanban): honor server bucket redirect on drag (#2618) - [`accb29b`](https://github.com/go-vikunja/vikunja/commit/accb29baaf1dddd91506207c5ef2e08c50440985) test(kanban): cover moveTaskToBucket - [`942bdc5`](https://github.com/go-vikunja/vikunja/commit/942bdc5689e101590e792f7965c5cfd9e8705d05) test(e2e/kanban): cover recurring task drag to done bucket (#2618) - [`830b546`](https://github.com/go-vikunja/vikunja/commit/830b546cfe989108e550d07cde0bdb51aea14b48) test(e2e/kanban): seed the view only once with done_bucket_id ### 📊 Changes **3 files changed** (+137 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/project/views/ProjectKanban.vue` (+1 -1) ➕ `frontend/src/stores/kanban.test.ts` (+93 -0) 📝 `frontend/tests/e2e/project/project-view-kanban.spec.ts` (+43 -0) </details> ### 📄 Description When a recurring task is dragged to the Done bucket, the backend correctly resets the task and returns a different `bucketId` in the response, but the frontend ignored that redirect — the card stayed visually in Done until the page was refreshed. The guard in `ProjectKanban.vue` that was meant to detect a server-side bucket change was tautologically false because `newTask.bucketId` was assigned from the response one line *before* the comparison. Reordered so the comparison fires on the pre-response bucket. Fixes #2618 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:51:52 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5775
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?