github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-15 22:32:29 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2616] [MERGED] refactor(projects): use getAllProjectsForUser in getProjectsToDelete #5772

New Issue
Closed
opened 2026-04-16 13:51:48 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:51:48 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2616
Author: @kolaente
Created: 4/13/2026
Status: ✅ Merged
Merged: 4/13/2026
Merged by: @kolaente

Base: main ← Head: claude/allow-delete-disabled-accounts-pa9tn

📝 Commits (1)

  • bf490dd fix(user): allow deleting disabled accounts via the cli

📊 Changes

2 files changed (+18 additions, -7 deletions)

View changed files

📝 pkg/models/user_delete.go (+5 -7)
📝 pkg/models/user_delete_test.go (+13 -0)

📄 Description

Summary

Refactored the getProjectsToDelete function to use the existing getAllProjectsForUser helper method instead of directly calling ReadAll, improving code reusability and consistency.

Key Changes

  • Replaced direct ReadAll call with getAllProjectsForUser helper function in getProjectsToDelete
  • Simplified project retrieval logic by using projectOptions struct with getArchived: true flag
  • Removed unnecessary nil check on the result since getAllProjectsForUser returns a properly typed slice
  • Added test case for deleting a disabled user (user ID 17) to ensure the refactored code handles this scenario correctly

Implementation Details

  • The refactoring maintains the same functionality while reducing code duplication
  • Uses projectOptions with page: 0, perPage: -1, and getArchived: true to match the previous behavior
  • The new test verifies that disabled users can be successfully deleted and properly removed from the database

https://claude.ai/code/session_01W4dMPFj321sB3oFdTi6qwc

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2616 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 4/13/2026 **Status:** ✅ Merged **Merged:** 4/13/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `claude/allow-delete-disabled-accounts-pa9tn` --- ### 📝 Commits (1) - [`bf490dd`](https://github.com/go-vikunja/vikunja/commit/bf490dd55bd45edf510b9c9e5a78af317232d7fa) fix(user): allow deleting disabled accounts via the cli ### 📊 Changes **2 files changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/user_delete.go` (+5 -7) 📝 `pkg/models/user_delete_test.go` (+13 -0) </details> ### 📄 Description ## Summary Refactored the `getProjectsToDelete` function to use the existing `getAllProjectsForUser` helper method instead of directly calling `ReadAll`, improving code reusability and consistency. ## Key Changes - Replaced direct `ReadAll` call with `getAllProjectsForUser` helper function in `getProjectsToDelete` - Simplified project retrieval logic by using `projectOptions` struct with `getArchived: true` flag - Removed unnecessary nil check on the result since `getAllProjectsForUser` returns a properly typed slice - Added test case for deleting a disabled user (user ID 17) to ensure the refactored code handles this scenario correctly ## Implementation Details - The refactoring maintains the same functionality while reducing code duplication - Uses `projectOptions` with `page: 0`, `perPage: -1`, and `getArchived: true` to match the previous behavior - The new test verifies that disabled users can be successfully deleted and properly removed from the database https://claude.ai/code/session_01W4dMPFj321sB3oFdTi6qwc --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:51:48 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5772
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?