github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2605] [CLOSED] ci: add explicit mysql:8 test matrix leg (non-blocking) #5762

New Issue
Closed
opened 2026-04-16 13:51:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:51:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2605
Author: @tink-bot
Created: 4/11/2026
Status: ❌ Closed

Base: main ← Head: ci-mysql-8-test

📝 Commits (3)

  • 71e524d ci: rename 'mysql' matrix leg to 'mariadb' to match reality
  • 5251554 ci: add non-blocking mysql:8 leg to test-api and test-migration-smoke
  • 3ae1345 ci: make mysql:8 matrix leg blocking

📊 Changes

1 file changed (+25 additions, -9 deletions)

View changed files

📝 .github/workflows/test.yml (+25 -9)

📄 Description

Adds an explicit mysql:8 service to the test-api and test-migration-smoke CI matrices so MySQL-specific strict-parsing regressions (the class of bug in #2589) are caught before release. Also renames the existing mysql matrix key to mariadb, since the leg was always pulling mariadb:12 — the old name was a lie.

Refs #2589
Depends on #2603 (the actual #2589 fix — not yet merged)

Notes for reviewers

  • The new mysql-8 leg is gated as experimental: true via a matrix include, with a job-level continue-on-error: ${{ matrix.experimental == true }}. It will not block unrelated PRs while the first-run surprises (MySQL 8 ONLY_FULL_GROUP_BY, collation, reserved words) are triaged.
  • go-sql-driver/mysql v1.9.3 already supports caching_sha2_password (MySQL 8 default auth), so no driver bump was needed.
  • mysql:8 digest sha256:da906917ca4ace3ba55538b7c2ee97a9bc865ef14a4b6920b021f0249d603f3d was resolved via the Docker Hub registry v2 manifest API on 2026-04-11.
  • actionlint passes on the resulting test.yml.

Deferred follow-ups (NOT in this PR)

  • Triage and fix any MySQL-8-only failures surfaced by the first green run (plan task 4).
  • Two-week stability hold on main after the leg is green (plan task 5).
  • Flip the leg from continue-on-error to blocking and add it to branch-protection required checks (plan task 6).

Why draft

#2603 (the #2589 fix) has not been merged yet. Until it lands on main, the new mysql-8 leg will fail from commit #1 on a CAST(... AS int) regression that is unrelated to this PR's scope. Once #2603 is merged, this PR can be rebased / re-run and marked ready for review.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2605 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/11/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `ci-mysql-8-test` --- ### 📝 Commits (3) - [`71e524d`](https://github.com/go-vikunja/vikunja/commit/71e524d7c159e3041476d7c7f275915dcb834d2d) ci: rename 'mysql' matrix leg to 'mariadb' to match reality - [`5251554`](https://github.com/go-vikunja/vikunja/commit/5251554db75d18edce89e8983ebc94e4273d7015) ci: add non-blocking mysql:8 leg to test-api and test-migration-smoke - [`3ae1345`](https://github.com/go-vikunja/vikunja/commit/3ae134590caf3edeaab00e15b86f242fa5725101) ci: make mysql:8 matrix leg blocking ### 📊 Changes **1 file changed** (+25 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+25 -9) </details> ### 📄 Description Adds an explicit `mysql:8` service to the `test-api` and `test-migration-smoke` CI matrices so MySQL-specific strict-parsing regressions (the class of bug in #2589) are caught before release. Also renames the existing `mysql` matrix key to `mariadb`, since the leg was always pulling `mariadb:12` — the old name was a lie. Refs #2589 Depends on #2603 (the actual #2589 fix — not yet merged) ## Notes for reviewers - The new `mysql-8` leg is gated as `experimental: true` via a matrix `include`, with a job-level `continue-on-error: ${{ matrix.experimental == true }}`. It will not block unrelated PRs while the first-run surprises (MySQL 8 `ONLY_FULL_GROUP_BY`, collation, reserved words) are triaged. - `go-sql-driver/mysql v1.9.3` already supports `caching_sha2_password` (MySQL 8 default auth), so no driver bump was needed. - `mysql:8` digest `sha256:da906917ca4ace3ba55538b7c2ee97a9bc865ef14a4b6920b021f0249d603f3d` was resolved via the Docker Hub registry v2 manifest API on 2026-04-11. - `actionlint` passes on the resulting `test.yml`. ## Deferred follow-ups (NOT in this PR) - Triage and fix any MySQL-8-only failures surfaced by the first green run (plan task 4). - Two-week stability hold on `main` after the leg is green (plan task 5). - Flip the leg from `continue-on-error` to blocking and add it to branch-protection required checks (plan task 6). ## Why draft #2603 (the #2589 fix) has not been merged yet. Until it lands on `main`, the new `mysql-8` leg will fail from commit #1 on a `CAST(... AS int)` regression that is unrelated to this PR's scope. Once #2603 is merged, this PR can be rebased / re-run and marked ready for review. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:51:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5762
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?