github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 02:32:22 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2576] [MERGED] fix(security): persist TOTP lockout across login rollback #5743

New Issue
Closed
opened 2026-04-16 13:50:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:50:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2576
Author: @tink-bot
Created: 4/9/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @kolaente

Base: main ← Head: fix-totp-lockout-rollback

📝 Commits (3)

  • cfb1bd4 fix(security): persist TOTP lockout across login rollback
  • 61ad911 test(user): cover TOTP lockout persistence and password-reset unlock
  • 18d38b5 test(webtests): add end-to-end TOTP lockout test

📊 Changes

4 files changed (+170 additions, -21 deletions)

View changed files

📝 pkg/routes/api/v1/login.go (+6 -2)
📝 pkg/user/totp.go (+48 -19)
📝 pkg/user/totp_test.go (+69 -0)
📝 pkg/webtests/login_test.go (+47 -0)

📄 Description

The 10-attempt TOTP lockout never fired: HandleFailedTOTPAuth wrote StatusAccountLocked on the login handler's xorm session, which was then unconditionally rolled back, leaving accounts open to brute-force once the password was known.

HandleFailedTOTPAuth now owns its own transaction and commits the lockout (and the attempt-3 warning notification) independently of the caller. The login handler rolls its own session back before invoking it so the two transactions do not contend for the users-table write lock on SQLite shared-cache. The attempt counter continues to live in the keyvalue store.

Fixes GHSA-fgfv-pv97-6cmj.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2576 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/9/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-totp-lockout-rollback` --- ### 📝 Commits (3) - [`cfb1bd4`](https://github.com/go-vikunja/vikunja/commit/cfb1bd440bff6d359bd4360bb540772bc4e9fac0) fix(security): persist TOTP lockout across login rollback - [`61ad911`](https://github.com/go-vikunja/vikunja/commit/61ad911c305f11c46e61c66983caa46689b9b52c) test(user): cover TOTP lockout persistence and password-reset unlock - [`18d38b5`](https://github.com/go-vikunja/vikunja/commit/18d38b5489bf7306345d7d81fd94a7c29669bd25) test(webtests): add end-to-end TOTP lockout test ### 📊 Changes **4 files changed** (+170 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `pkg/routes/api/v1/login.go` (+6 -2) 📝 `pkg/user/totp.go` (+48 -19) 📝 `pkg/user/totp_test.go` (+69 -0) 📝 `pkg/webtests/login_test.go` (+47 -0) </details> ### 📄 Description The 10-attempt TOTP lockout never fired: `HandleFailedTOTPAuth` wrote `StatusAccountLocked` on the login handler's xorm session, which was then unconditionally rolled back, leaving accounts open to brute-force once the password was known. `HandleFailedTOTPAuth` now owns its own transaction and commits the lockout (and the attempt-3 warning notification) independently of the caller. The login handler rolls its own session back before invoking it so the two transactions do not contend for the users-table write lock on SQLite shared-cache. The attempt counter continues to live in the keyvalue store. Fixes GHSA-fgfv-pv97-6cmj. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:50:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5743
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?