github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-21 02:32:22 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2575] [MERGED] fix(security): prevent file size limit bypass via import (GHSA-qh78-rvg3-cv54) #5742

New Issue
Closed
opened 2026-04-16 13:50:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:50:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2575
Author: @tink-bot
Created: 4/9/2026
Status: ✅ Merged
Merged: 4/9/2026
Merged by: @kolaente

Base: main ← Head: fix-import-file-size-bypass

📝 Commits (6)

  • 30bf9f5 fix(files): derive file size from reader at creation boundary
  • 3d0c343 refactor(files): derive attachment size from content in sibling callers
  • 42f93dd fix(migration): compute attachment size from content during import
  • 3f47e2c fix(migration): bound per-entry zip cap by configured files.maxsize
  • d754c1a test(migration): regression test for forged attachment size
  • d5dd913 test(todoist): serve attachment from local test server

📊 Changes

10 files changed (+244 additions, -25 deletions)

View changed files

📝 pkg/files/files.go (+48 -3)
📝 pkg/files/files_test.go (+54 -3)
📝 pkg/models/project_duplicate.go (+1 -1)
📝 pkg/models/task_attachment_test.go (+3 -2)
📝 pkg/models/task_duplicate.go (+1 -1)
📝 pkg/modules/migration/create_from_structure.go (+6 -2)
📝 pkg/modules/migration/todoist/todoist.go (+1 -1)
📝 pkg/modules/migration/todoist/todoist_test.go (+21 -4)
📝 pkg/modules/migration/vikunja-file/vikunja.go (+36 -8)
📝 pkg/modules/migration/vikunja-file/vikunja_test.go (+73 -0)

📄 Description

The Vikunja file import endpoint trusted the attacker-supplied Size field from the JSON metadata inside the import zip when enforcing files.maxsize, so setting "size": 0 while stuffing arbitrarily large content into the corresponding files/<id> zip entry bypassed the limit and could fill server disk.

This PR fixes the immediate bypass at the import layer and adds defense in depth at the file creation boundary so future callers cannot reintroduce the same class of bug.

Reference: GHSA-qh78-rvg3-cv54

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2575 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/9/2026 **Status:** ✅ Merged **Merged:** 4/9/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-import-file-size-bypass` --- ### 📝 Commits (6) - [`30bf9f5`](https://github.com/go-vikunja/vikunja/commit/30bf9f5eaf727e257cd1733e8521fc1a1847681e) fix(files): derive file size from reader at creation boundary - [`3d0c343`](https://github.com/go-vikunja/vikunja/commit/3d0c3432098552a916e7edc338ce596f8fd91236) refactor(files): derive attachment size from content in sibling callers - [`42f93dd`](https://github.com/go-vikunja/vikunja/commit/42f93dddd8ca10cd6e1be74eaab4b2c5eec4001a) fix(migration): compute attachment size from content during import - [`3f47e2c`](https://github.com/go-vikunja/vikunja/commit/3f47e2c4fb3f20eed78b11aa8dd003a638192cff) fix(migration): bound per-entry zip cap by configured files.maxsize - [`d754c1a`](https://github.com/go-vikunja/vikunja/commit/d754c1af10368e27ef6cd4c68cda2c38a6782d8d) test(migration): regression test for forged attachment size - [`d5dd913`](https://github.com/go-vikunja/vikunja/commit/d5dd913fdc02358fbba0b6ec7e4d6ce4c0dcc184) test(todoist): serve attachment from local test server ### 📊 Changes **10 files changed** (+244 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `pkg/files/files.go` (+48 -3) 📝 `pkg/files/files_test.go` (+54 -3) 📝 `pkg/models/project_duplicate.go` (+1 -1) 📝 `pkg/models/task_attachment_test.go` (+3 -2) 📝 `pkg/models/task_duplicate.go` (+1 -1) 📝 `pkg/modules/migration/create_from_structure.go` (+6 -2) 📝 `pkg/modules/migration/todoist/todoist.go` (+1 -1) 📝 `pkg/modules/migration/todoist/todoist_test.go` (+21 -4) 📝 `pkg/modules/migration/vikunja-file/vikunja.go` (+36 -8) 📝 `pkg/modules/migration/vikunja-file/vikunja_test.go` (+73 -0) </details> ### 📄 Description The Vikunja file import endpoint trusted the attacker-supplied `Size` field from the JSON metadata inside the import zip when enforcing `files.maxsize`, so setting `"size": 0` while stuffing arbitrarily large content into the corresponding `files/<id>` zip entry bypassed the limit and could fill server disk. This PR fixes the immediate bypass at the import layer and adds defense in depth at the file creation boundary so future callers cannot reintroduce the same class of bug. Reference: GHSA-qh78-rvg3-cv54 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:50:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?