github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-07 03:58:09 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2564] [MERGED] fix: use type-safe keyvalue caching to fix Redis avatar/preview cache #5733

New Issue
Closed
opened 2026-04-16 13:50:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:50:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2564
Author: @tink-bot
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @kolaente

Base: main ← Head: fix-avatar-cache-redis

📝 Commits (4)

  • feeba8d feat: add generic RememberValue[T] for type-safe keyvalue caching
  • cf7172b fix: register gob types and use RememberValue for avatar and unsplash cache
  • 9284655 fix: use RememberValue for task attachment preview cache
  • 1d2d0ef test: remove obsolete invalid-cache-type test for avatar upload

📊 Changes

5 files changed (+51 additions, -68 deletions)

View changed files

📝 pkg/models/task_attachment.go (+2 -2)
📝 pkg/modules/avatar/upload/upload.go (+15 -38)
📝 pkg/modules/avatar/upload/upload_test.go (+0 -25)
📝 pkg/modules/background/unsplash/unsplash.go (+6 -3)
📝 pkg/modules/keyvalue/keyvalue.go (+28 -0)

📄 Description

The Remember() function in the keyvalue package uses Get() to check the cache, but the Redis implementation of Get() returns a raw string without gob-decoding. Since Put() gob-encodes non-integer values, the returned string can never be type-asserted back to the original struct type (e.g. CachedAvatar, Photo, []byte). This causes avatar caching, unsplash photo caching, and task attachment preview caching to break completely when Redis is used as the keyvalue backend.

This adds a generic RememberValue[T]() function that uses GetWithValue() internally for proper gob-deserialization, and migrates all three affected callers to use it.

Fixes https://github.com/go-vikunja/vikunja/issues/2217

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2564 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-avatar-cache-redis` --- ### 📝 Commits (4) - [`feeba8d`](https://github.com/go-vikunja/vikunja/commit/feeba8d8f1e21923a5b4a778fd279a430e1233a1) feat: add generic RememberValue[T] for type-safe keyvalue caching - [`cf7172b`](https://github.com/go-vikunja/vikunja/commit/cf7172bb22c9e7e9028f6a392cfd875dd54004da) fix: register gob types and use RememberValue for avatar and unsplash cache - [`9284655`](https://github.com/go-vikunja/vikunja/commit/92846555b378ab0db9895f1f8ec50f300db76348) fix: use RememberValue for task attachment preview cache - [`1d2d0ef`](https://github.com/go-vikunja/vikunja/commit/1d2d0ef9aacc239c9edb09b7795165d2d6463883) test: remove obsolete invalid-cache-type test for avatar upload ### 📊 Changes **5 files changed** (+51 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/task_attachment.go` (+2 -2) 📝 `pkg/modules/avatar/upload/upload.go` (+15 -38) 📝 `pkg/modules/avatar/upload/upload_test.go` (+0 -25) 📝 `pkg/modules/background/unsplash/unsplash.go` (+6 -3) 📝 `pkg/modules/keyvalue/keyvalue.go` (+28 -0) </details> ### 📄 Description The `Remember()` function in the keyvalue package uses `Get()` to check the cache, but the Redis implementation of `Get()` returns a raw string without gob-decoding. Since `Put()` gob-encodes non-integer values, the returned string can never be type-asserted back to the original struct type (e.g. `CachedAvatar`, `Photo`, `[]byte`). This causes avatar caching, unsplash photo caching, and task attachment preview caching to break completely when Redis is used as the keyvalue backend. This adds a generic `RememberValue[T]()` function that uses `GetWithValue()` internally for proper gob-deserialization, and migrates all three affected callers to use it. Fixes https://github.com/go-vikunja/vikunja/issues/2217 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:50:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5733
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?