github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 12:57:52 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2563] [MERGED] fix(background): use targeted column update when removing background #5732

New Issue
Closed
opened 2026-04-16 13:50:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:50:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2563
Author: @tink-bot
Created: 4/8/2026
Status: ✅ Merged
Merged: 4/8/2026
Merged by: @kolaente

Base: main ← Head: fix-background-delete-title

📝 Commits (3)

  • 526fc15 feat(models): add ClearProjectBackground for scoped column update
  • 055ecd1 fix(background): use targeted column update when removing background
  • 13978d0 test: verify background removal preserves project title

📊 Changes

4 files changed (+49 additions, -5 deletions)

View changed files

📝 pkg/models/project.go (+9 -0)
📝 pkg/modules/background/handler/background.go (+2 -5)
📝 pkg/webtests/background_test.go (+31 -0)
📝 pkg/webtests/integrations.go (+7 -0)

📄 Description

RemoveProjectBackground passed a minimal Project struct (only ID set) through UpdateProject, which always includes title in its Cols() list, causing XORM to overwrite the real project title with an empty string.

Fixes #2552

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2563 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/8/2026 **Status:** ✅ Merged **Merged:** 4/8/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-background-delete-title` --- ### 📝 Commits (3) - [`526fc15`](https://github.com/go-vikunja/vikunja/commit/526fc158bd550c7e7597b11e4efb4dc3f348c663) feat(models): add ClearProjectBackground for scoped column update - [`055ecd1`](https://github.com/go-vikunja/vikunja/commit/055ecd1832899fc9a7c82c7834e0d1729f8d8c72) fix(background): use targeted column update when removing background - [`13978d0`](https://github.com/go-vikunja/vikunja/commit/13978d0dfcd00cdb30c28debccd3a166da255327) test: verify background removal preserves project title ### 📊 Changes **4 files changed** (+49 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `pkg/models/project.go` (+9 -0) 📝 `pkg/modules/background/handler/background.go` (+2 -5) 📝 `pkg/webtests/background_test.go` (+31 -0) 📝 `pkg/webtests/integrations.go` (+7 -0) </details> ### 📄 Description `RemoveProjectBackground` passed a minimal `Project` struct (only ID set) through `UpdateProject`, which always includes `title` in its `Cols()` list, causing XORM to overwrite the real project title with an empty string. Fixes #2552 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:50:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5732
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?