github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-07-15 22:32:29 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2542] [MERGED] feat: remove flexsearch dependency and replace with simple string filtering #5718

New Issue
Closed
opened 2026-04-16 13:50:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:50:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2542
Author: @kolaente
Created: 4/4/2026
Status: ✅ Merged
Merged: 4/4/2026
Merged by: @kolaente

Base: main ← Head: claude/investigate-issue-298-XCEJE

📝 Commits (2)

  • 1957b39 bench: add FlexSearch vs String.includes() comparison for label/project search
  • 81af94c fix: replace FlexSearch with String.includes() for label and project search

📊 Changes

6 files changed (+21 additions, -101 deletions)

View changed files

📝 frontend/package.json (+0 -1)
📝 frontend/pnpm-lock.yaml (+0 -8)
➖ frontend/src/indexes/index.ts (+0 -51)
📝 frontend/src/stores/labels.ts (+5 -11)
📝 frontend/src/stores/projects.test.ts (+0 -9)
📝 frontend/src/stores/projects.ts (+16 -21)

📄 Description

This PR removes the flexsearch library and its associated indexing infrastructure, replacing it with simple string-based filtering for projects and labels. The change simplifies the codebase by removing unnecessary complexity for what amounts to basic substring matching.

Resolves https://github.com/go-vikunja/vikunja/issues/298

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2542 **Author:** [@kolaente](https://github.com/kolaente) **Created:** 4/4/2026 **Status:** ✅ Merged **Merged:** 4/4/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `claude/investigate-issue-298-XCEJE` --- ### 📝 Commits (2) - [`1957b39`](https://github.com/go-vikunja/vikunja/commit/1957b3918d67b5285ef10490f382a3b39d62075f) bench: add FlexSearch vs String.includes() comparison for label/project search - [`81af94c`](https://github.com/go-vikunja/vikunja/commit/81af94c6ed2e41866191f6f82b2a2a1f320e5a1b) fix: replace FlexSearch with String.includes() for label and project search ### 📊 Changes **6 files changed** (+21 additions, -101 deletions) <details> <summary>View changed files</summary> 📝 `frontend/package.json` (+0 -1) 📝 `frontend/pnpm-lock.yaml` (+0 -8) ➖ `frontend/src/indexes/index.ts` (+0 -51) 📝 `frontend/src/stores/labels.ts` (+5 -11) 📝 `frontend/src/stores/projects.test.ts` (+0 -9) 📝 `frontend/src/stores/projects.ts` (+16 -21) </details> ### 📄 Description This PR removes the flexsearch library and its associated indexing infrastructure, replacing it with simple string-based filtering for projects and labels. The change simplifies the codebase by removing unnecessary complexity for what amounts to basic substring matching. Resolves https://github.com/go-vikunja/vikunja/issues/298 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:50:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5718
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?