github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 19:47:47 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2536] [MERGED] fix(mail): set RFC 5322 compliant Message-ID using public URL domain #5712

New Issue
Closed
opened 2026-04-16 13:49:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:49:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2536
Author: @tink-bot
Created: 4/3/2026
Status: ✅ Merged
Merged: 4/3/2026
Merged by: @kolaente

Base: main ← Head: fix-smtp-message-id

📝 Commits (6)

  • c1102e7 feat(mail): add GetMailDomain helper for RFC 5322 compliant email IDs
  • 1f10493 fix(mail): set RFC 5322 compliant Message-ID using public URL domain
  • 45236b6 refactor(models): use shared GetMailDomain in getThreadID
  • d3a6e34 fix(mail): fall back to os.Hostname() before hardcoded domain
  • 22fdaab refactor(mail): use CryptoRandomString for Message-ID generation
  • 72ef092 fix(mail): guard log calls in GetMailDomain and fix hostname-dependent tests

📊 Changes

7 files changed (+171 additions, -11 deletions)

View changed files

📝 pkg/log/logging.go (+5 -0)
➕ pkg/mail/domain.go (+47 -0)
➕ pkg/mail/domain_test.go (+57 -0)
📝 pkg/mail/send_mail.go (+7 -0)
➕ pkg/mail/send_mail_test.go (+42 -0)
📝 pkg/models/notifications.go (+2 -9)
📝 pkg/models/notifications_test.go (+11 -2)

📄 Description

Outgoing emails now set an explicit Message-ID header using the hostname from the configured public URL, instead of relying on go-mail's default which calls os.Hostname() -- unreliable in Docker/Kubernetes where it returns the container ID.

Fixes #2522

Also extracts the domain-from-URL logic into a shared GetMailDomain() helper and refactors getThreadID() to reuse it.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2536 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/3/2026 **Status:** ✅ Merged **Merged:** 4/3/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-smtp-message-id` --- ### 📝 Commits (6) - [`c1102e7`](https://github.com/go-vikunja/vikunja/commit/c1102e75dcb001e824f6d9b419bcbe0594d9c3e7) feat(mail): add GetMailDomain helper for RFC 5322 compliant email IDs - [`1f10493`](https://github.com/go-vikunja/vikunja/commit/1f10493ed92e09df6fae3a0e1ae928be199d01c5) fix(mail): set RFC 5322 compliant Message-ID using public URL domain - [`45236b6`](https://github.com/go-vikunja/vikunja/commit/45236b610df4a2fa41dcf42c464ca04a8caae638) refactor(models): use shared GetMailDomain in getThreadID - [`d3a6e34`](https://github.com/go-vikunja/vikunja/commit/d3a6e34af15a9f108792dc7e6b26760ca9b6a061) fix(mail): fall back to os.Hostname() before hardcoded domain - [`22fdaab`](https://github.com/go-vikunja/vikunja/commit/22fdaab275b448de4181396ca7524062bc121373) refactor(mail): use CryptoRandomString for Message-ID generation - [`72ef092`](https://github.com/go-vikunja/vikunja/commit/72ef092c7786db5b08ced954cdded54df8c114e6) fix(mail): guard log calls in GetMailDomain and fix hostname-dependent tests ### 📊 Changes **7 files changed** (+171 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `pkg/log/logging.go` (+5 -0) ➕ `pkg/mail/domain.go` (+47 -0) ➕ `pkg/mail/domain_test.go` (+57 -0) 📝 `pkg/mail/send_mail.go` (+7 -0) ➕ `pkg/mail/send_mail_test.go` (+42 -0) 📝 `pkg/models/notifications.go` (+2 -9) 📝 `pkg/models/notifications_test.go` (+11 -2) </details> ### 📄 Description Outgoing emails now set an explicit Message-ID header using the hostname from the configured public URL, instead of relying on go-mail's default which calls `os.Hostname()` -- unreliable in Docker/Kubernetes where it returns the container ID. Fixes #2522 Also extracts the domain-from-URL logic into a shared `GetMailDomain()` helper and refactors `getThreadID()` to reuse it. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:49:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?