github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-06 03:27:53 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2528] [MERGED] fix: show subtasks in saved filter views regardless of parent presence #5704

New Issue
Closed
opened 2026-04-16 13:49:36 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:49:36 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2528
Author: @tink-bot
Created: 4/2/2026
Status: ✅ Merged
Merged: 4/3/2026
Merged by: @kolaente

Base: main ← Head: fix-subtask-filter-visibility

📝 Commits (3)

  • b342691 test: add failing tests for subtask visibility in filtered views
  • 147adfd fix: show subtasks in saved filter views regardless of parent presence
  • 569f968 fix: pass saved filter context to subtask visibility check

📊 Changes

3 files changed (+60 additions, -1 deletions)

View changed files

📝 frontend/src/components/project/views/ProjectList.vue (+2 -1)
📝 frontend/src/composables/useTaskListFiltering.test.ts (+48 -0)
📝 frontend/src/composables/useTaskListFiltering.ts (+10 -0)

📄 Description

Subtasks were hidden in saved/custom filter views when their parent task was also in the results, because the parent-hiding logic (designed for regular project list views) was applied unconditionally. This adds an isFilteredView flag to skip that logic when viewing tasks through a saved filter.

Fixes #2494

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2528 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/2/2026 **Status:** ✅ Merged **Merged:** 4/3/2026 **Merged by:** [@kolaente](https://github.com/kolaente) **Base:** `main` ← **Head:** `fix-subtask-filter-visibility` --- ### 📝 Commits (3) - [`b342691`](https://github.com/go-vikunja/vikunja/commit/b342691f13eebabb4ae4a18678a7b324115dc630) test: add failing tests for subtask visibility in filtered views - [`147adfd`](https://github.com/go-vikunja/vikunja/commit/147adfdbb6c2bc21191eaa4058c8896d7a34ad19) fix: show subtasks in saved filter views regardless of parent presence - [`569f968`](https://github.com/go-vikunja/vikunja/commit/569f9683c6704466305d98293ff051e8dfbb351b) fix: pass saved filter context to subtask visibility check ### 📊 Changes **3 files changed** (+60 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/project/views/ProjectList.vue` (+2 -1) 📝 `frontend/src/composables/useTaskListFiltering.test.ts` (+48 -0) 📝 `frontend/src/composables/useTaskListFiltering.ts` (+10 -0) </details> ### 📄 Description Subtasks were hidden in saved/custom filter views when their parent task was also in the results, because the parent-hiding logic (designed for regular project list views) was applied unconditionally. This adds an `isFilteredView` flag to skip that logic when viewing tasks through a saved filter. Fixes #2494 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:49:36 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5704
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?