github-starred/vikunja
2
0
Fork 0
mirror of https://github.com/go-vikunja/vikunja.git synced 2026-05-08 04:48:27 -05:00
Code Issues 690 Packages Projects Releases 11 Wiki Activity

[PR #2527] [CLOSED] feat: add PKCE support to frontend OIDC authentication #5703

New Issue
Closed
opened 2026-04-16 13:49:34 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-16 13:49:34 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/go-vikunja/vikunja/pull/2527
Author: @tink-bot
Created: 4/2/2026
Status: ❌ Closed

Base: main ← Head: fix-oidc-pkce-support

📝 Commits (4)

  • fb8e4ea feat: add PKCE utility functions for OIDC auth
  • f5024e2 feat: include PKCE code_challenge in OIDC auth redirect
  • 4c56553 feat: send PKCE code_verifier during OIDC token exchange
  • f24b15c fix: pass PKCE code_verifier to OIDC provider during token exchange

📊 Changes

4 files changed (+50 additions, -6 deletions)

View changed files

➕ frontend/src/helpers/pkce.ts (+30 -0)
📝 frontend/src/helpers/redirectToProvider.ts (+7 -2)
📝 frontend/src/stores/auth.ts (+4 -0)
📝 pkg/modules/auth/openid/openid.go (+9 -4)

📄 Description

The frontend OIDC flow never sent code_challenge / code_challenge_method parameters, causing authentication to fail against any provider that requires PKCE (RFC 7636) -- including Vikunja's own OAuth2 server.

Fixes #2410

Test plan

  • Configure an OIDC provider that requires PKCE (or use Vikunja's own OAuth2 server)
  • Click "Login with [Provider]" and verify the authorization redirect URL contains code_challenge=...&code_challenge_method=S256
  • After authenticating, verify the callback POST contains code_verifier in the body
  • Verify login succeeds end-to-end

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/go-vikunja/vikunja/pull/2527 **Author:** [@tink-bot](https://github.com/tink-bot) **Created:** 4/2/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-oidc-pkce-support` --- ### 📝 Commits (4) - [`fb8e4ea`](https://github.com/go-vikunja/vikunja/commit/fb8e4ea741b71397aad44fbd60d6e5ba3de9542f) feat: add PKCE utility functions for OIDC auth - [`f5024e2`](https://github.com/go-vikunja/vikunja/commit/f5024e2f2ce6b3b4fa0391fde1afaef69aa55bbd) feat: include PKCE code_challenge in OIDC auth redirect - [`4c56553`](https://github.com/go-vikunja/vikunja/commit/4c565537e4afe14297f0b1d22215895c2f783a40) feat: send PKCE code_verifier during OIDC token exchange - [`f24b15c`](https://github.com/go-vikunja/vikunja/commit/f24b15c6e953ecfd81ac611143bacc4be11c044a) fix: pass PKCE code_verifier to OIDC provider during token exchange ### 📊 Changes **4 files changed** (+50 additions, -6 deletions) <details> <summary>View changed files</summary> ➕ `frontend/src/helpers/pkce.ts` (+30 -0) 📝 `frontend/src/helpers/redirectToProvider.ts` (+7 -2) 📝 `frontend/src/stores/auth.ts` (+4 -0) 📝 `pkg/modules/auth/openid/openid.go` (+9 -4) </details> ### 📄 Description The frontend OIDC flow never sent `code_challenge` / `code_challenge_method` parameters, causing authentication to fail against any provider that requires PKCE (RFC 7636) -- including Vikunja's own OAuth2 server. Fixes #2410 ## Test plan - Configure an OIDC provider that requires PKCE (or use Vikunja's own OAuth2 server) - Click "Login with [Provider]" and verify the authorization redirect URL contains `code_challenge=...&code_challenge_method=S256` - After authenticating, verify the callback POST contains `code_verifier` in the body - Verify login succeeds end-to-end --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-16 13:49:34 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/api
area/attachments
area/auth
area/avatars
area/backup-restore
area/caldav
area/calendar-view
area/comments
area/config
area/database
area/desktop
area/docker
area/email
area/favorites
area/filters
area/frontend
area/gantt
area/i18n
area/import-export
area/internal-code
area/kanban
area/labels
area/list-view
area/mobile
area/notifications
area/permissions
area/projects
area/pwa
area/recurring-tasks
area/reminders
area/search
area/shortcuts
area/subtasks
area/sync
area/table-view
area/task-editor
area/task-metadata
area/task-relations
area/teams
area/theming
area/time-tracking
area/typesense
area/views
area/webhooks
bug
changes requested
concern/accessibility
concern/performance
concern/regression
concern/ux
confirmed
db/mysql
dependencies
enhancement
good first issue
help wanted
integration/inbound
integration/outbound
kind/bug
kind/feature
needs reproduction
pull-request
Mirrored from GitHub Pull Request
 question
security
support
upstream issue
waiting for reply
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/vikunja#5703
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?